Repository navigation
feat(setup): Add shell completions and embedded agent skills - #908
Merged
MathurAditya724 merged 31 commits intoOct 15, 2026
Merged
Conversation
Contributor
|
BYK
requested changes
Oct 14, 2026
This was referenced Oct 15, 2026
# Conflicts: # .github/workflows/build.yml # .github/workflows/release-build.yml
MathurAditya724
marked this pull request as ready for review
October 15, 2026 18:12
BYK
pushed a commit
that referenced
this pull request
Oct 15, 2026
Craft can build Node-embedded executables for macOS/Linux ARM64 and x64 plus Windows x64 while retaining the existing JavaScript bundle and npm entry points. Pinned Fossilize reuses the esbuild/Sentry bundle; the existing Ubuntu job cross-builds the five targets once and compresses Unix outputs with gzip. Checksum-pinned rcodesign supplies macOS ad-hoc signatures. Following review, native release checksum sidecars and their generation loop are removed. The macOS ARM64 verification job downloads the artifact, extracts it, verifies its Apple signature, and executes --version. The later completion PR (#908) adds the full five-platform CLI/installer/setup distribution suite. Developer ID/notarization and Windows Authenticode are not configured. Existing nightly/workflow tests pass locally. Build foundation for #903–#909; release integration follows in #904. Ready for review.
Base automatically changed from
codex/native-updater
to
codex/native-installer
October 15, 2026 18:45
An error occurred while trying to automatically change base from
codex/native-updater
to
codex/native-installer
October 15, 2026 18:45
Add a Bash HTTPS installer and native setup command, plus manual standalone updates using verified binpatch output with full-download fallback. Keep npm and Homebrew updates with their package managers. Use dry-run-aware staging, placement locking, Unix atomic replacement, and Windows backup/rollback. Check candidate versions and macOS signatures before replacing binaries.
Base automatically changed from
codex/native-installer
to
codex/fossilize-homebrew
October 15, 2026 20:21
Resolve conflicts after the installer and updater squash merge while preserving the reviewed completion integration and distribution tests.
Embed a version-pinned Craft workflow skill in native and npm builds. Install into detected agent roots during setup, persist opt-out preferences, and refresh skills after standalone updates. Preserve custom files, symlinks, and dry-run behavior. Validated with Node 22/24 and all five native CI targets, plus focused local tests, typecheck, and lint.
Base automatically changed from
codex/fossilize-homebrew
to
codex/fossilize-releases
October 15, 2026 20:36
MathurAditya724
changed the title
Retain completion and agent-skill setup when merging the native-release branch. Include embedded skills in the isolated AI-summary build fixture.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
craft completion [shell]prints Bash, zsh, or fish scripts backed by the installed CLI metadata.craft setupinstalls completion files and an embedded, version-pinnedcraft-cliskill into detected agent roots. Standalone placement remains optional through--install, so npm/pnpm and Homebrew installations can configure integrations directly.Setup uses standard XDG/user directories, supports both CLI aliases, preserves custom files and file symlinks, respects dry-run, and prints shell-loading instructions without editing profiles. Completion queries stop at the cursor and skip telemetry. Agent-skill opt-out persists across setup and standalone updates; refresh failures warn without undoing a successful binary update.
The shared Vitest distribution suite exercises actual native/npm artifacts, installer failure preservation, shell completion, and embedded skills on macOS/Linux ARM64/x64 and Windows x64. Linux x64 also exercises real zsh/fish contexts. The isolated AI-summary build fixture includes embedded skills so the merged CLI and Action integration can build together.
Stacked on #904's native-release branch. Squash-merging here carries completion and agent skills into that branch; #904 remains the PR targeting master.