fix(tracing): report spans whose parent lives on another node - #1171
Open
solnic wants to merge 1 commit into
Open
fix(tracing): report spans whose parent lives on another node#1171solnic wants to merge 1 commit into
solnic wants to merge 1 commit into
Conversation
solnic
force-pushed
the
fix/otel-remote-parent-spans
branch
from
August 13, 2026 14:45
4b0ebed to
a29744e
Compare
solnic
marked this pull request as ready for review
August 13, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a service continued a trace from a
traceparentand its local root was anything other than an HTTP-server / LiveView / Oban-consumer span etc.,process_span/1fell through to theserver_span?/1heuristic and the entire local subtree was silently dropped.SpanRecordalready carries OTel'sparent_span_is_remote, so the local root of remotely-continued trace can be identified directly and reported as its own segment.build_trace_context/2already passesparent_span_idthrough, so it nests under the upstream transaction.This works on every supported opentelemetry version.
parent_span_is_remoteonly exists on the span record from opentelemetry >=1.6, so on1.5.x(what Elixir 1.13/1.14 lock) the span processor derives it from the parent span context aton_startand carries it via an internal attribute that never reaches a payload.Before
After
Fixes #1166