Skip to content

fix(samples): Make Nav2 sample dark-mode compatible - #6066

Merged
0xadam-brown merged 1 commit into
mainfrom
chore/nav2-sample-dark-mode
Sep 7, 2026
Merged

fix(samples): Make Nav2 sample dark-mode compatible#6066
0xadam-brown merged 1 commit into
mainfrom
chore/nav2-sample-dark-mode

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Sep 7, 2026

Copy link
Copy Markdown
Member

📜 Description

Resolve the remaining light-only colors in the Nav2 sample so the view and Compose paths follow the active DayNight theme.

Replace fixed black and white surfaces and text with theme-derived colors, and let the Compose hosts render their own themed backgrounds instead of forcing white containers.

💡 Motivation and Context

Follow-up to @runningcode's comment here.

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

#skip-changelog

Resolve the remaining light-only colors in the Nav2 sample so the view and Compose paths follow the active DayNight theme.

Replace fixed black and white surfaces and text with theme-derived colors, and let the Compose hosts render their own themed backgrounds instead of forcing white containers.

Refs #6060
Co-Authored-By: OpenCode <noreply@opencode.ai>
@0xadam-brown 0xadam-brown added the ship-it PR is ready to merge from a reviewer perspective label Sep 7, 2026
@sentry

sentry Bot commented Sep 7, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.55.0 (1) release

⚙️ sentry-android Build Distribution Settings

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8089740. Configure here.

@runningcode runningcode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice! color theme is mostly bike shedding but thanks for fixing it!

@0xadam-brown
0xadam-brown merged commit 0dbf275 into main Sep 7, 2026
36 checks passed
@0xadam-brown
0xadam-brown deleted the chore/nav2-sample-dark-mode branch September 7, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ship-it PR is ready to merge from a reviewer perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants