chore(deps): update Native SDK to v0.17.1 - #6135
github-actions[bot] wants to merge 1 commit into
Conversation
733d364 to
339dfaa
Compare
📲 Install BuildsAndroid
|
1889a64 to
54cd0cf
Compare
54cd0cf to
58df0b5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 58df0b5. Configure here.
| retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" } | ||
| retrofit-gson = { module = "com.squareup.retrofit2:converter-gson", version.ref = "retrofit" } | ||
| sentry-native-ndk = { module = "io.sentry:sentry-native-ndk", version = "0.16.6" } | ||
| sentry-native-ndk = { module = "io.sentry:sentry-native-ndk", version = "0.17.0" } |
There was a problem hiding this comment.
Native crash marker consumed too early
High Severity
Native SDK 0.17.0 makes sentry_init() consume .sentry-native/last_crash after caching it. NdkIntegration still calls init during Sentry.init, before EnvelopeCache and PreviousSessionFinalizer read that file. After a native crash, the previous session is no longer marked Crashed and isCrashedLastRun() can return false, especially below API 31 where tombstones do not backfill this.
Triggered by project rule: PR Review Guidelines for Cursor Bugbot
Reviewed by Cursor Bugbot for commit 58df0b5. Configure here.
There was a problem hiding this comment.
As far as I can see there's a new sentry__retain_crash_marker method, which reverses this behavior just for Android: https://github.com/getsentry/sentry-native/pull/2023/changes#diff-e4d142a5c832bd54ef2d2d6d3cce1ea262ad322017b8c963a56d813d7f4cc230R444
But yeah, we need to do some testing on this before merging.
fd1659c to
5cd6070
Compare
5cd6070 to
5cd0f8c
Compare


Bumps scripts/update-sentry-native-ndk.sh from 0.16.6 to 0.17.1.
Auto-generated by a dependency updater.
Changelog
0.17.1
Fixes:
on_crashcallback is set. (#2133)0.17.0
Breaking / Important behavior changes:
sentry_value_tandsentry_uuid_tinstead ofsentry_attachment_t *handles. Most attachment APIs, function names and arguments, are otherwise unchanged. (#1974)sentry_init()now consumes<db>/last_crashafter caching its value, aligning crashed-last-run behavior with other Sentry SDKs. (#2023)hintparameter ofbefore_sendcallbacks (sentry_event_function_t) fromvoid *tosentry_hint_t *. Update callbacks registered withsentry_options_set_before_sendto use the new parameter type. (#2099)sentry_hint_t *hintargument toon_crashcallbacks. (#2112)sentry_hint_t *hintargument tosentry_scope_capture_event. PassNULLif no hint is needed. (#2099)sentry_options_get/set_enable_logsandsentry_options_get/set_enable_metrics. (#1980)Features:
sentry_attachment_from_file/bytes(and their wide-string variants) for creating attachment values that can be fully configured before they are added. (#2079)sentry_add_attachment,sentry_scope_add_attachment, andsentry_hint_add_attachmentfor adding configured attachments to the global scope, a specific scope, or a hint. These functions consume and freeze the attachment value. (#2079, #1974)sentry_start_new_trace()as a clearer name for starting a new trace. (#2095)sentry_scope_capture_eventto pass event-specific attachments. The hint is also passed tobefore_sendandon_crash, which can modify attachments before the event is sent. (#2099, #2112)sentry_hint_get_attachments,sentry_hint_remove_attachment, andsentry_hint_clear_attachments. (#2099)Fixes:
Other changes:
Deprecations:
sentry_clear_crashed_last_run()becausesentry_init()now consumes the marker automatically. (#2023)sentry_regenerate_trace()in favor ofsentry_start_new_trace(). (#2095)0.16.8
Features:
sentry_options_set_initial_scopefor configuring scope data before the crash backend is started, including out-of-process crash handlers. (#2087)Fixes:
Thank you:
0.16.7
Important:
This version was accidentally released from
masterand includes breaking changes intended for0.17. It is superseded by0.16.8, which restores compatibility with0.16.6and includes the intended hotfixes.See https://github.com/getsentry/sentry-native/releases/tag/0.16.7 for the original changelog.