fix(ci): Unblock external-contributors checkout on fork PR merges#22235
Open
Lms24 wants to merge 1 commit into
Open
fix(ci): Unblock external-contributors checkout on fork PR merges#22235Lms24 wants to merge 1 commit into
Lms24 wants to merge 1 commit into
Conversation
actions/checkout@v7 refuses any checkout in pull_request_target workflows triggered by fork PRs. Explicitly check out develop and opt in so the changelog credit workflow can run after external merges. Co-Authored-By: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external-contributors workflow started failing after #21898 bumped
actions/checkoutto v7. That release blocks checkout inpull_request_targetworkflows when the triggering PR came from a fork, even when only checking out the base branch.This PR ensures we explicitly check out
developand setallow-unsafe-pr-checkout: true.The workflow never uses fork PR code. It only reads PR metadata from the
event payload and updates CHANGELOG.md on develop.
Broken run: https://github.com/getsentry/sentry-javascript/actions/runs/29263604917