Skip to content

Support cached properties - #38

Open
rixx wants to merge 2 commits into
ghickman:mainfrom
rixx:cached-property
Open

Support cached properties#38
rixx wants to merge 2 commits into
ghickman:mainfrom
rixx:cached-property

Conversation

@rixx

@rixx rixx commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ghickman

ghickman commented Sep 8, 2026

Copy link
Copy Markdown
Owner

@rixx – could you rebase this over main to get the CI fix please?

@rixx

rixx commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

@ghickman done, but with the other PR reverted, cached properties now land in both methods and properties, as this was leaning on the callable check more than I realised (would have put it in the same PR). Do you want me to add and not is_cached_property(member) to is_method, or do you want another overall approach?

@rixx

rixx commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

I'm pushing a change to tests that checks that attributes are not present multiple times in the classify output. This will turn the test suite red so this PR does not get accidentally merged while it's in this state.

Looking at classify() some more, might me more worth it to iterate over members once and figure out what each should be, because including this PR, classify is up to six versions of [m for m in members if …].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants