Repository navigation
fix(skills): skip remote plugin sources in marketplace.json - #32
Merged
Merged
Conversation
Claude Code marketplaces may give a plugin entry an object source, such
as {"source": "archive", ...} or {"source": "github", ...}, for a plugin
hosted outside the marketplace repository. clime decoded `source` as a
string, so one such entry failed the whole marketplace.json parse and
the catalog fell back to scanning only the top level of skills/, dropping
every skill listed at a nested path.
Decode `source` as raw JSON and skip plugins whose source is not a
relative path: their files are not in the repository snapshot.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
git-hulk
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Claude Code marketplaces can give a plugin entry an object
sourcefor a plugin hosted outside the marketplace repository:github,url,git-subdir,npm,archive, orcommand(marketplace reference). For example:{"name": "aha-skills", "source": {"source": "archive", "url": "https://example.com/aha-skills.zip"}, "skills": ["./aha-react-ui-generator"]}marketplacePlugin.Sourceis astring, so a single entry like this makesjson.Unmarshalfail for the wholemarketplace.json.ReadCatalogthen falls back toreadSkillsDir("skills"), which only lists the top level ofskills/. Every skill that the marketplace lists at a nested path disappears fromclime skills install.Behavior change
sourceis decoded asjson.RawMessage.sourceis a string, or absent, works as before.sourceis an object is skipped. Its files are not in the repository snapshot, so clime cannot install them, which matches the design rule that skills are read from the snapshot.Installing remote-source plugins is out of scope here.
Test evidence
New test
TestReadCatalogFromMarketplaceSkipsRemoteSourcescovers a local plugin with a nested skill path next toarchive,github, andgit-subdirentries. It fails onmaster(the catalog falls back toskills/unlisted) and passes with this change.gofmt -lis clean.go vet ./...andgo test ./...pass withLC_ALL=C. Without it,TestSnapshotReportsFetchProgressAndKeepsCacheHitsSilentfails on a machine whose git prints localized progress; that failure is unrelated to this change.I also ran
ReadCatalogagainst a copy of a real marketplace (AfterShip/skills) after moving three skills into anarchiveentry:masterskills/cli/clime-cli,skills/cli/files-cli,skills/qa-common/*×3,skills/pltf-nf/enter,skills/infrastructure/query)🤖 Generated with Claude Code