feat: accept multiple references in add and remove - #73
Merged
Conversation
A release configuration could only name one reference per `remove` entry, so depopulating a board variant meant one line per part. `add` accepted several references but only when separated by commas, which left the released BOM mixing comma-separated references on added lines with space-separated ones everywhere else. That also meant a reference added by one operation could never be removed by another, since removal matched on space-separated references. Both operations now take several references in a single `ref` field, separated by spaces or commas, and added references are stored space-separated to match the rest of the BOM. Added references are also sorted, using the sortRefs helper that was already present but never called. Existing configurations keep working: a single reference and comma-separated lists are both still accepted. Claude-Session: https://claude.ai/code/session_01Y2dKhCQGfRFMwJbrvcDmxJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release configuration could only name one reference per
removeentry, so depopulating a board variant meant one line per part.addaccepted several references but only when separated by commas, which left the released BOM mixing comma-separated references on added lines with space-separated ones everywhere else. That also meant a reference added by one operation could never be removed by another, since removal matched on space-separated references.Both operations now take several references in a single
reffield, separated by spaces or commas, and added references are stored space-separated to match the rest of the BOM. Added references are also sorted, using the sortRefs helper that was already present but never called.Existing configurations keep working: a single reference and comma-separated lists are both still accepted.