Actions: The regex wasn't escaping external input - #22240
Merged
aschackmull merged 4 commits intoJul 31, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes regex handling in the Actions output-clobbering query.
Changes:
- Replaces dynamic regex construction with literal command lookup.
- Adds regression cases for metacharacters and
env echo. - Updates expected query results and change notes.
Show a summary per file
| File | Description |
|---|---|
OutputClobberingQuery.qll |
Avoids embedding source input in a regex. |
output2.yml |
Adds regression scenarios. |
OutputClobberingHigh.expected |
Updates expected findings. |
2026-07-28-output-clobbering-regex.md |
Documents the fix. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Medium
JarLob
force-pushed
the
fix/actions-output-clobbering-regex
branch
from
July 31, 2026 09:40
c745d74 to
b9a5dd4
Compare
…obbering-regex # Conflicts: # actions/ql/test/query-tests/Security/CWE-074/OutputClobberingHigh.expected
aschackmull
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.