[review] docs: document sink-visibility field in MCP Gateway write-sink guard policy (spec v1.15.0) by github-actions[bot] · Pull Request #44320 · github/gh-aw

github-actions · 2026-07-08T15:03:13Z

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Reason: agent_failure

Review the workflow run logs for details.

This PR contains changes that were originally intended for PR #44305 (copilot/document-sink-visibility-field).
Please review the changes carefully before merging.

Generated by 👨‍🍳 PR Sous Chef · 6.93 AIC · ⌖ 5.06 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · 6.55 AIC · ⌖ 5.29 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

…spec - Add Section 4.1.3.8 documenting the new `forcePublicRepos` gateway config field - Add `forcePublicRepos` to the gateway config fields table (Section 4.1.3) - Add Section 10.8 — Write-Sink Guard Policy with full `sink-visibility` field specification, enforcement model, DIFC semantics, runtime verification, and compiler behavior - Add Section 10.9 — Cross-Visibility Opt-Out documenting `private-to-public-flows: allow` frontmatter option, its constraints, compiler responsibilities, and interaction matrix - Add compliance test category 11.1.12 with T-WS-001 through T-WS-008 - Update compliance checklist with Write-Sink Guard Policy row - Add changelog entry for spec version 1.15.0 - Update both JSON schema files (docs/public and pkg/workflow) with: - New `writeSinkGuardPolicyConfig` definition with `accept` and `sink-visibility` fields - Typed `write-sink` property in `guard-policies` for both stdioServerConfig and httpServerConfig - New `forcePublicRepos` boolean field in `gatewayConfig` - Added `guard-policies` to `stdioServerConfig` in docs/public schema (was missing) Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

…nition Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

gh-aw-bot · 2026-07-08T16:02:20Z

@copilot please run the pr-finisher skill, ensure the branch is up to date, and rerun checks.

Generated by 👨‍🍳 PR Sous Chef · 6.93 AIC · ⌖ 5.06 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-08T16:15:08Z

@copilot please run the pr-finisher skill, ensure the branch is up to date, and rerun checks.

...

Checked PR #44320 on head 7ee209b: the branch is already up to date with base copilot/document-sink-visibility-field (f94d875 is the current base tip and ancestor of HEAD). Local validation passed with make fmt, make lint, make test-unit, make test, and make recompile. I can’t re-run GitHub Actions checks from this cloud agent, but the existing Copilot run on this head is already in progress: https://github.com/github/gh-aw/actions/runs/28957025063

gh-aw-bot · 2026-07-08T16:49:33Z

@copilot please run the pr-finisher skill, make any remaining updates needed to get this PR ready, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 6.55 AIC · ⌖ 5.29 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-08T17:06:02Z

@copilot please run the pr-finisher skill, make any remaining updates needed to get this PR ready, and rerun checks once the branch is up to date.

...

Updated the branch in 1d01dec by merging main, resolving the overlap with the already-landed docs/schema changes, and reducing the PR diff to the remaining changeset file. Local validation passed with make fmt, make lint, make test-unit, make test, make recompile, and make agent-report-progress. GitHub created new runs on the updated head automatically; if you need a fresh full CI pass beyond that, a maintainer will need to retrigger it.

gh-aw-bot · 2026-07-08T17:30:01Z

pr-sous-chef
@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 6.43 AIC · ⌖ 4.84 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-08T17:44:10Z

pr-sous-chef
@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.
...

I checked the current PR state: there are no unresolved in-scope review threads or review comments to address, and the only prior CI result on the current head is Smoke CI in action_required with no failed jobs to fix. I also tried to bring the branch up to date with main, but git fetch --unshallow origin timed out on all 3 attempts from the cloud agent, so I couldn’t safely refresh the branch here. A maintainer can re-trigger CI after updating or pushing the branch if needed.

Copilot AI and others added 7 commits July 8, 2026 13:39

Initial plan

d8dfdc7

fix: restore missing type and description in opentelemetryConfig defi…

a20b4e2

…nition Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

docs: clarify sink-visibility enforcement model and fallback behavior

e6f943f

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

docs: fix grammar, wording, and contradiction in mcp-gateway spec

804b963

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Merge branch 'main' into copilot/document-sink-visibility-field

f94d875

Add changeset for sink visibility docs

7ee209b

github-actions Bot added the needs-review label Jul 8, 2026

This was referenced Jul 8, 2026

docs: document sink-visibility field in MCP Gateway write-sink guard policy (spec v1.15.0) #44305

Merged

[aw] Smoke Copilot reported incomplete result #44329

Closed

github-actions Bot mentioned this pull request Jul 8, 2026

[pr-sous-chef] Run report — 6 nudged, 0 skipped #44348

Closed

Copilot started work on behalf of gh-aw-bot July 8, 2026 16:03 View session

Copilot AI requested a review from gh-aw-bot July 8, 2026 16:15

Copilot finished work on behalf of gh-aw-bot July 8, 2026 16:15

Base automatically changed from copilot/document-sink-visibility-field to main July 8, 2026 16:22

Copilot started work on behalf of gh-aw-bot July 8, 2026 16:50 View session

Merge origin/main into review branch

1d01dec

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 8, 2026 17:06

github-actions Bot mentioned this pull request Jul 8, 2026

[pr-sous-chef] Run report — 5 nudged, 0 skipped #44369

Closed

Copilot started work on behalf of gh-aw-bot July 8, 2026 17:30 View session

Copilot finished work on behalf of gh-aw-bot July 8, 2026 17:44

This was referenced Jul 8, 2026

[aw] Smoke Codex is missing required data #44385

Closed

[pr-sous-chef] Run report — 0 nudged, 4 skipped #44393

Closed

[pr-sous-chef] Run report — 5 nudged, 2 skipped #44408

Closed

pelikhan closed this Jul 9, 2026

github-actions Bot added the closed:unknown PR was closed without merging: unknown label Jul 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[review] docs: document sink-visibility field in MCP Gateway write-sink guard policy (spec v1.15.0)#44320

[review] docs: document sink-visibility field in MCP Gateway write-sink guard policy (spec v1.15.0)#44320
github-actions[bot] wants to merge 8 commits into
mainfrom
copilot/document-sink-visibility-field-review-1783522988692

github-actions Bot commented Jul 8, 2026 •

edited

Loading

Uh oh!

gh-aw-bot commented Jul 8, 2026

Uh oh!

Copilot AI commented Jul 8, 2026

Uh oh!

gh-aw-bot commented Jul 8, 2026

Uh oh!

Copilot AI commented Jul 8, 2026

Uh oh!

gh-aw-bot commented Jul 8, 2026

Uh oh!

Copilot AI commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

github-actions Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gh-aw-bot commented Jul 8, 2026

Uh oh!

Copilot AI commented Jul 8, 2026

Uh oh!

gh-aw-bot commented Jul 8, 2026

Uh oh!

Copilot AI commented Jul 8, 2026

Uh oh!

gh-aw-bot commented Jul 8, 2026

Uh oh!

Copilot AI commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 8, 2026 •

edited

Loading