Skip to content

Fix _doing_it_wrong notice from admin notice script on WP 6.9+ block editor #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smoen-godaddy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix _doing_it_wrong notice from admin notice script on WP 6.9+ block editor #864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion woocommerce/class-sv-wc-admin-notice-handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,18 @@ function log_dismissed_notice( pluginID, messageID ) {
} ) ( jQuery );
<?php

ScriptHelper::addInlineScript($plugin_slug.'-admin-notices', ob_get_clean());
$js = ob_get_clean();

// WP 6.9+ calls wp_print_footer_scripts() during block editor initialisation
// (_wp_get_iframed_editor_assets), incrementing the global did_action counter before
// admin_footer fires. ScriptHelper::addInlineScript() triggers _doing_it_wrong in that
// state, and wp_add_inline_script() queues the script too late to be printed.
// Fall back to a direct script tag so the notice JS always runs.
if ( did_action( 'wp_print_footer_scripts' ) ) {
wp_print_inline_script_tag( $js );
} else {
ScriptHelper::addInlineScript( $plugin_slug . '-admin-notices', $js );
}
}


Expand Down