Implement Sqlite.backup - #60
Open
joeybright wants to merge 2 commits into
Open
Conversation
Implementation and integration tests for the `backup` SQLite function
blaix
reviewed
Aug 22, 2026
blaix
left a comment
blaix
left a comment
Contributor
There was a problem hiding this comment.
LGTM, pending one test fixup. Will leave it to Robin for final approval.
…gotten from original database
robinheghan
requested changes
Aug 24, 2026
robinheghan
left a comment
robinheghan
left a comment
Member
There was a problem hiding this comment.
Small nitpick, but otherwise it looks good!
I agree that we can figure out progress updates at a later stage.
|
|
||
| runBackup : Backup -> Task Error {} | ||
| runBackup (Backup { destination, pages, db }) = | ||
| Gren.Kernel.Sqlite.backup (FileSystem.Path.toPosixString destination) pages db |
Member
There was a problem hiding this comment.
You should move the toString call to kernel code, and use _FilePath_toString, which takes the current platform into account (generates win-paths on win-systems).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backupSQLite functionprogressfunctionality provided by the SQLite node module, but ran into a lot of issues trying to get it to work with Gren streams. It's purely additive, though, and doesn't block the essential functionality that is working in this PR. We can add it in a later release, I think.