Repository navigation
Conversation
Signed-off-by: Christian Selzer <s6chselz@uni-bonn.de>
Signed-off-by: Christian Selzer <s6chselz@uni-bonn.de>
Signed-off-by: Christian Selzer <s6chselz@uni-bonn.de>
Member
|
could you explain a bit more: was the problem that no projection was done for linear molecules or that projection before mass weighting changed frequencies significantly in a non-linear case or both? and can you give an example to show both? it might make sense to pin relevant behavior in unit tests. also after merging #1446 this might need some slight updates (there is already a merge conflict) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the projection of the rot/trans modes were done before the mass weighting. In the dxtb project as well as the gaussian white paper reads as if the correct way to do this is, however, after the massweighting. this lead to problems as no projection was done for linear molecules resulting in wrong frequencies. This patch should elevate this problem, works also for fixed atoms. Testing on the in #693 mentioned linear water molecules yields now two -1802.38 cm^-1 modes. the ordering in the vibspectrum file also seems to be correct now.
This should therefore close #693 .