Skip to content

notification - #523

Merged
awindsr merged 10 commits into
gtech-mulearn:devfrom
Yadhuthhiyyakat:dev
Sep 22, 2026
Merged

awindsr merged 10 commits into
gtech-mulearn:devfrom
Yadhuthhiyyakat:dev

Conversation

@Yadhuthhiyyakat

Copy link
Copy Markdown
Contributor
image

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

@Yadhuthhiyyakat is attempting to deploy a commit to the awindsr's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-project-automation github-project-automation Bot moved this to Backlog in µlearn 5.0 Sep 18, 2026
@netlify

netlify Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

👷 Deploy request for staging-mulearn pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9d74b3d

@awindsr

awindsr commented Sep 22, 2026

Copy link
Copy Markdown
Member

@greptileai

@greptile-apps

greptile-apps Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR is not yet safe to merge because bulk selection still submits broadcast notification IDs that the endpoint skips while reporting them as marked read.

Findings

  1. P1 Selection Includes Skipped Broadcasts ▶

Summary

The latest changes add paginated loading to the unified notification feed and flatten fetched pages for display in the notification popover.

  • Replaces the single-page notification query with a TanStack infinite query.
  • Adds a “Load older notifications” action when more pages are available.
  • Keeps feed and unread-count cache invalidation integrated with notification mutations.
  • The earlier admin-dispatch, clear-personal, and pagination findings are resolved; selection still includes broadcast notifications even though the bulk-read endpoint skips them.
Diagram
sequenceDiagram
  participant User
  participant Popover as Notification Popover
  participant Query as Infinite Query
  participant API as Notification API
  User->>Popover: Open notifications
  Popover->>Query: Request page 1
  Query->>API: "GET feed?page=1&page_size=20"
  API-->>Query: Results and pagination metadata
  Query-->>Popover: Render accumulated pages
  User->>Popover: Load older notifications
  Popover->>Query: fetchNextPage()
  Query->>API: GET next page
  API-->>Query: Older notifications
  Query-->>Popover: Flatten and render all pages
Loading

Reviews (5) · Last reviewed commit: "Notification pagination fixed"

Comment on lines +72 to +73
// IDs eligible for selection (unread only; broadcast IDs are silently skipped by the server)
const selectableIds = unreadNotifications.map((n) => n.id);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Selection Includes Skipped Broadcasts

This selection list includes every unread result even though the code states that the bulk-read endpoint skips broadcast IDs. Selecting both personal and broadcast items sends all IDs and reports the full submitted count as marked read, while skipped broadcasts remain unread.

@awindsr awindsr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the issues mentioned

@awindsr
awindsr merged commit bb1ad35 into gtech-mulearn:dev Sep 22, 2026
4 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Integration Testing in µlearn 5.0 Sep 22, 2026
@github-project-automation github-project-automation Bot moved this from Triage to QA in µLearn Delivery Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA
Status: Integration Testing

Development

Successfully merging this pull request may close these issues.

2 participants