[Sub-org] Fix Excel export hiding the row grouping gutter - #14624
Merged
garyhtou merged 1 commit intoAug 19, 2026
Conversation
garyhtou
approved these changes
Aug 19, 2026
Member
|
force merged bc GH actions is down; so merge queue doesn't work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
The collapsible tree added in #14540 renders correctly in Google Sheets but the grouping gutter is missing entirely in Excel.
Unzipping an exported file shows the row grouping is present and correct:
...but so is this:
showOutlineSymbols="0"tells Excel to hide the outline gutter. Google Sheets ignores the attribute and draws the grouping anyway, which is why it only reproduced in Excel.It comes from
outline_settings(1, 0, 0, 0).write_xlsxguards that flag with a bare truthiness check:0is truthy in Ruby, so any number turns it on — passing1forvisible(meaning "show them") is exactly what hides them. The same bug on line 4322 is why exports also carried a strayapplyStyles="1"despiteauto_stylebeing0.Describe your changes
falseforvisibleandauto_style, the only valuewrite_xlsxreads as off for those two.symbols_below/symbols_rightuse a correct== 0check, so0stays right there.falseback to1.showOutlineSymbolsis absent from the sheet in the existing tree spec, so this can't silently regress if the gem ever fixes its logic.Verified against
write_xlsx1.12.3 directly — emitted XML after the change: