Repository navigation
[drone] import should translate invalid characters in secret IDs #116
Description
Similar to what we did in drone/go-convert#108, the import command for Drone should translate invalid characters to safe characters allowed in Harness secret IDs.
For example, MY-SECRET is valid in Drone, but it is an invalid Harness secret ID. In the Harness API call, MY-SECRET should convert to MY_SECRET (the name of the secret can remain MY-SECRET).
Activity
jimsheldon commentedon Jul 3, 2023
It seems this work is still required.
The secret name and ID are created from just the secret name, which can have invalid characters since it comes directly from the export.
https://github.com/harness/harness-migrate/blob/master/internal/migrate/import.go#L101C23-L101C23
https://github.com/harness/harness-migrate/blob/master/internal/util/util.go#L32-L33
fix: [CODE-3891]: Update README (#116)
Revert Pull Request #116 "fix: [CODE-3891]: Update README"
Revert Pull Request #116 "fix: [CODE-3891] Update README" (#117)