fix: parent-scoped list deep links and coding standards guardrail - #758
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Add pipelineScopedListExtract for child resources listed under a pipeline - Fix trigger and input_set list openInHarness using child identifier - Fix trigger delete to require pipeline_id as targetIdentifier - Add coding-standards test to block bare pageExtract on parent deep links Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Coding standards review found that
triggerandinput_setlist results could generate incorrectopenInHarnessdeep links (childidentifiersubstituted for parentpipeline_id). PR #756 fixes triggers; this change completes the pattern for input sets and adds an automated guardrail.Changes:
parentScopedListExtract/pipelineScopedListExtractinextractors.tsto inject parent scope onto list rowstriggerandinput_setlist operations inpipelines.tstrigger.deleteto requirepipeline_idastargetIdentifierquery paramparent-scoped-list-deep-links.test.tsregression testspageExtractwhendeepLinkTemplateneeds a parent identifier fieldType of Change
Checklist
pnpm testpasses (2721 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (78 guardrail tests)pnpm docs:checkpassesCoding Standards (registry-driven MCP model)
server.registerTool()calls — only toolset/extractor changessrc/registry/extractors.tsconsole.log()insrc/Standards review summary
The repo enforces architecture rules via
pnpm standards:check(77+ tests) in CI. All checks pass onmain. This PR adds one more guardrail for parent-scoped list deep links.