Skip to content

fix: parent-scoped list deep links and coding standards guardrail - #758

Closed
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/mcp-server-coding-standards-1830
Closed

cursor[bot] wants to merge 1 commit into
mainfrom
cursor/mcp-server-coding-standards-1830

Conversation

@cursor

@cursor cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

Coding standards review found that trigger and input_set list results could generate incorrect openInHarness deep links (child identifier substituted for parent pipeline_id). PR #756 fixes triggers; this change completes the pattern for input sets and adds an automated guardrail.

Changes:

  • Add parentScopedListExtract / pipelineScopedListExtract in extractors.ts to inject parent scope onto list rows
  • Apply to trigger and input_set list operations in pipelines.ts
  • Fix trigger.delete to require pipeline_id as targetIdentifier query param
  • Add parent-scoped-list-deep-links.test.ts regression tests
  • Add coding-standards test blocking bare pageExtract when deepLinkTemplate needs a parent identifier field

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other

Checklist

  • pnpm test passes (2721 tests)
  • pnpm typecheck passes
  • pnpm build passes
  • pnpm standards:check passes (78 guardrail tests)
  • pnpm docs:check passes

Coding Standards (registry-driven MCP model)

  • No new server.registerTool() calls — only toolset/extractor changes
  • Shared response extractors from src/registry/extractors.ts
  • No console.log() in src/

Standards review summary

The repo enforces architecture rules via pnpm standards:check (77+ tests) in CI. All checks pass on main. This PR adds one more guardrail for parent-scoped list deep links.

Open in Web View Automation 

- Add pipelineScopedListExtract for child resources listed under a pipeline
- Fix trigger and input_set list openInHarness using child identifier
- Fix trigger delete to require pipeline_id as targetIdentifier
- Add coding-standards test to block bare pageExtract on parent deep links

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants