test: regression coverage for schema sync #874 (istio routing, NotificationRules) - #875
Closed
cursor[bot] wants to merge 2 commits into
Closed
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…cationRules) Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds contract tests for upstream schema changes synced in auto-sync PR #874.
Triggered by: PR #874 (
chore: auto-sync harness schemas)Risky behavior now covered
pipelineandtemplatebundles — upstream removed the deprecatedsmiprovider; onlyistioremains. Without a contract test, a bad sync could silently reintroducesmior drop the istio conditional$ref.harness_schemamust seegateways,hosts, anddelegateService(not the removedrootService/SMIProviderSpec).allowedOverrides— upstream addedNotificationRulesso template consumers can override notification config; a dropped enum entry would break valid template YAML.Test files added/updated
tests/schemas/schema-bundle-contract.test.ts— three new cases:drops the removed smi provider from K8sTrafficRoutingSpec in v0 pipeline and templateincludes upstream IstioProviderSpec traffic-routing fields in v0 pipeline and templateincludes NotificationRules in pipeline template allowedOverridesWhy these tests materially reduce regression risk
Schema auto-sync PRs are high-volume and low-review. CD traffic-routing and template override enums are easy to regress during upstream merges (duplicate definitions, stale provider enums). These follow the existing bundle-contract pattern used for other upstream step additions.
Validation
pnpm test tests/schemas/schema-bundle-contract.test.ts— 19/19 passedType of Change
Checklist
pnpm testpasses (targeted: schema bundle contract)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpassesNote
This branch includes the #874 schema sync commit so tests pass in CI. Merge after or in place of #874; only the test commit is net-new coverage.