test: cover user aggregate API routing and recent schema sync contracts - #882
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regression test coverage for recently merged production changes with meaningful business risk and no dedicated tests.
Risky behavior now covered
User get aggregate API (fix: route user get through the aggregate API #876) —
GET /ng/api/user/{userId}returns 405 on ng-manager (surfaced as 500). The fix routes throughGET /ng/api/user/aggregate/{userId}. Tests lock the endpoint spec andregistry.dispatchpath so a revert re-breaks user lookups.HttpStepInfo authentication conditionals (chore: auto-sync harness schemas #869) — Schema sync added
if/thenrequired-field branches for Basic, BearerToken, and ApiKey auth types. Contract tests assert each branch requires the correctspecfields in v0 pipeline and template bundles.UnifiedStageNodeV1 permissions (chore: auto-sync harness schemas #864) — v1 pipeline/template stages gained a
permissionsobject for scoped stage RBAC. Contract tests assert the field exists with the expected description.Istio-only K8s traffic routing (chore: auto-sync harness schemas #874) — Upstream removed SMI provider support and consolidated
IstioProviderSpec(gateways/hosts/delegateService). Contract tests assertistiois the sole provider enum value and SMI/rootService are absent.Test files added/updated
tests/registry/access-control.test.ts(11 tests)tests/schemas/schema-bundle-contract.test.ts(+3 contract tests)Why these tests materially reduce regression risk
harness_get(resource_type="user")would hit a disallowed endpoint without these guards.Type of Change
Checklist
pnpm testpasses (28/28 targeted tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpassesValidation