Repository navigation
Run full-string checks when no assembly follows - #1436
Merged
Merged
Conversation
A ColumnSource whose as_base_input() returns None never reaches stage 4, so stage 3 now passes full_string=True to validate_hed_column for it. The group-level checks are otherwise lost for a caller that never assembles rows (ndx-hed assemble=False). A source that offers a BaseInput is unchanged: basic checks in stage 3, group-level checks once in stage 4.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Cell-level checks can reject valid multi-column annotations, and the early assembly call can mask stage-3 errors.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
This PR adds full-string HED checks for column sources that cannot assemble rows, so those checks are not skipped.
Changes:
- Run full-string checks in stage 3 when
as_base_input()returnsNone. - Add tests for sources with and without assembly.
| File | Description |
|---|---|
tests/validator/test_staged_validation.py |
Tests the new stage-3 behavior and existing assembly path. |
hed/validator/spreadsheet_validator.py |
Selects where full-string checks run. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
VisLab
added a commit
to VisLab/hed-python
that referenced
this pull request
Sep 30, 2026
Copilot review of PR hed-standard#1436. as_base_input() is called only once stages 2 and 3 have passed, so a stage 3 error never costs a table conversion; a source with no BaseInput then gets the group-level checks on each distinct HED cell in a second pass. Those cell checks skip the required-tag and unique-tag rules (run_full_string_checks whole_row=False) unless the HED column is the row's only HED, since the sidecar may supply the missing tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ColumnSource whose as_base_input() returns None never reaches stage 4, so stage 3 now passes full_string=True to validate_hed_column for it. The group-level checks are otherwise lost for a caller that never assembles rows (ndx-hed assemble=False). A source that offers a BaseInput is unchanged: basic checks in stage 3, group-level checks once in stage 4.