You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copilot review of PR hed-standard#1437. A sidecar string is a fragment of a row, so the sidecar stage no longer runs the required-tag check on it; required tags split between a sidecar string and the HED column validate clean. The unique-tag check still runs there, since a unique tag repeated inside a fragment is repeated in the row and hed-tests has a sidecar-only TAG_NOT_UNIQUE case. run_full_string_checks takes required_tags and unique_tags in place of whole_row; the HED-cell pass passes both False.
SchemaComparer iterated sets of row keys, extras section names, and attribute names, so the order of the 'Row ... missing in first schema' lines and of an entry's attribute changes changed with the hash seed from run to run. The changelog this feeds (hed-schemas PRERELEASE_CHANGES.md) is a generated, committed file, so every regeneration showed spurious reorderings. The three loops now run in sorted order. Tests pin the order for one-sided rows through _compare_dataframes and through gather_schema_changes.
Copilot review of PR hed-standard#1438. required_tags and unique_tags on HedValidator.run_full_string_checks can no longer be passed positionally, so a positional call cannot silently change meaning. The whole_row flag they replace lived on main for one day between PRs hed-standard#1437 and hed-standard#1438 and never reached a release, so no compatibility parameter is kept for it.
With full_string=True, this method is explicitly serving a caller that will not assemble rows, so disabling unique_tags drops a definite TAG_NOT_UNIQUE violation. A duplicate unique tag inside this fragment remains duplicated in any assembled row; keep only the required-tag check disabled. The normal staged path uses full_string=False, so this will not duplicate stage 4 reports.
This issue also appears on line 411 of the same file.
Copilot re-review of PR hed-standard#1438. The cell pass that runs when no assembly follows, and validate_hed_column(full_string=True), now skip only the required-tag check. A unique tag repeated inside one cell is repeated in every assembled row, so the check cannot false-alarm there; it is reported once per distinct string with a row count. The two paths never run together with assembly, so nothing is reported twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.