You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dateTimeClass values are matched with the BIDS Datetime regex (RFC 3339
with an optional offset), the rule hed-specification publishes in
character_sets.json: fractions of one to six digits, hour 00-23, seconds
00-60, offset Z or +hh:mm. Hour 24, longer fractions and out-of-range
fields no longer pass. numericClass uses ASCII digits only.
class_util.py loses the second, unreachable date-time rule
(fromisoformat, rejecting any zone) and everything that existed only to
reach it: the per-class validator map, the value_validators parameter,
the is_* helpers, the clock-face check and find_invalid_positions. The
tests of those functions become whole-value tests.
Copilot review of PR hed-standard#1439: UnitValueValidator(value_validators=...)
was a documented parameter, so it stays accepted until 2.0.0 with a
DeprecationWarning. It has no effect, as before in practice: the only
code that consulted the injected functions was never reached by
validation. Registered in tests/test_deprecations.py with the other
2.0.0 removals.
Retain deprecated is_clock_face_time wrapper and schedule its removal
hed/validator/util/class_util.py:28
This compatibility shim leaves another removed API behind: is_clock_face_time was explicitly marked deprecated, but this PR deletes it without retaining a warning wrapper or adding it to SCHEDULED_REMOVALS, whose stated policy is to track every deprecated item. Direct callers now fail immediately while the similarly deprecated constructor parameter remains available until 2.0.0. Keep the helper as a warning wrapper and schedule its removal for the same major release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.