[Patiga]

Here I just went with the existing readers and added the required functionality.
I like the relatively small changes, and think this is the best solution for now, and also mergable.

In the interpreted reader interface I needed to expose if a tick chunk is marked as a keyframe. This is a breaking change sadly.
The only immediate change I would recommend alongside this one is to rename the ddnet module to something else, as it is generic over the protocol.

[heinrich5991]

Looks very well-thought out. Thanks for the PR.

It'd be best if this wasn't a binary, but a test that was automatically run on changes, but I don't have a repository of demos right now and wouldn't know where to store them without bloating this git repository, so whatever. The binary is a good building block for such a test.

[Patiga]

For now I only exposed next_chunk_type on the high level reader. It could also be added to the lower abstraction reader, however that one has kind of a different idea what the chunk types are.

[Patiga]

ah, gotta rebase on master

[Patiga]

Fixed three inconsistencies:

• rename ChunkType::NetMessage to ChunkType::Message
• all the seek functions only use io::Error now
• bug in keyframe seeking where it wouldn't seek back to the initial position

[Patiga]

imo this can be merged now, would also appreciate a crates.io bump.
I've already integrated this change into twsnap and twgpu with demo seeking, and it appears to work nice at the highest level.

[Patiga]

resolved the previous comments, will squash if nothing else comes up.

I was wondering if the seek, stream_position methods should also return ReadError for consistency? They do only return io::Errors the way they work right now.
Also a rename of the ddnet module might be sensible, but I struggle to come up with a good name.

[heinrich5991]

I was wondering if the seek, stream_position methods should also return ReadError for consistency? They do only return io::Errors the way they work right now.

You decide.

Also a rename of the ddnet module might be sensible, but I struggle to come up with a good name.

Yes, but me too.

resolved the previous comments, will squash if nothing else comes up.

Squash I guess. Thanks for bearing with me.

[Patiga]

I changed the return error type to always be ReadError.
The module staying as ddnet is fine by me. Only fine alternative I came up with now is gamenet

[Patiga]

Closes #140