Repository navigation
gamenet default fallback on decoding - #149
Merged
Merged
Conversation
Default values are used on `UnexpectedEnd` errors.
Collaborator
Author
|
I switched to f-strings as I'm more used to writing them. At the time this script was written they probably didn't exist yet. If I should use the older formatting style, I can do that ofc |
heinrich5991
approved these changes
Aug 25, 2026
heinrich5991
left a comment
heinrich5991
left a comment
Owner
There was a problem hiding this comment.
Yea, looks sensible. Thanks. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify gamenet generation script to consider default values. kinda(?) solves #122
Note that this does not fix the case mentioned by @Jupeyy, as there is no default values for tunes in the spec.
However, this does in particular add default values to
DdnetCharacter, which is arguably one of the most important snap objects.The default value is only used, if a
UnexpectedEnderror occurs.