Skip to content

resty: default appstore_service_name to helx-appstore - #110

Merged
joshua-seals merged 2 commits into
masterfrom
fix/resty-appstore-service-name
Aug 3, 2026
Merged

joshua-seals merged 2 commits into
masterfrom
fix/resty-appstore-service-name

Conversation

@joshua-seals

Copy link
Copy Markdown
Collaborator

Full disclosure, I'm back and forth on whether a default is worth having - this addresses an inconsistency I observed in deploying the de-ambassador changes though.

The de-Ambassador resty config resolves static upstreams (proxy_pass without an nginx variable: /private-route, /auth, /) at startup and refuses to boot if one is unresolvable. The umbrella deploys with Release.Name=helx, so the appstore Service is "helx-appstore", but the default was plain "appstore" -> "host not found in upstream" CrashLoopBackOff. Match the ui_service_name: helx-ui convention so a stock helm install works without a --set override.

Chart version 4.5.5 -> 4.5.6.

@frostyfan109

Copy link
Copy Markdown
Contributor

It's still a somewhat common pattern to deploy each chart required for helx individually. I typically prefer this since it allows you to easily install local versions of the chart without having to package them into a local version of the helx chart. So you could do something like if Chart.IsRoot then appstore else .Release.Name-appstore

@joshua-seals

Copy link
Copy Markdown
Collaborator Author

It's still a somewhat common pattern to deploy each chart required for helx individually. I typically prefer this since it allows you to easily install local versions of the chart without having to package them into a local version of the helx chart. So you could do something like if Chart.IsRoot then appstore else .Release.Name-appstore

I also prefer that individual deployment pattern - so this is not super critical unless using the helx-chart. All that to say, this should be very different with the monorepo project. All these changes will eventually change again in that overarching helm.

@joshua-seals
joshua-seals force-pushed the fix/resty-appstore-service-name branch from 1e91767 to 920920b Compare August 3, 2026 17:19
The de-Ambassador resty config resolves static upstreams (proxy_pass without an
nginx variable) at startup and refuses to boot if one is unresolvable. The host
comes from global.{appstore,ui}_service_name.

Default them based on how resty is deployed instead of hardcoding a prefix:
- Chart.IsRoot (resty deployed on its own)      -> "appstore" / "ui"
- subchart of the umbrella (Release.Name=helx)  -> "<release>-appstore" / "<release>-ui"

values.yaml leaves both null so the template default applies; an explicit
global.{appstore,ui}_service_name still overrides. Fixes the CrashLoopBackOff
seen deploying the umbrella (Service was "helx-appstore" but default was
"appstore") and works for any release name. sockets/airflow keep fixed
non-release-prefixed defaults.

Chart version 4.5.5 -> 4.5.6.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@joshua-seals
joshua-seals force-pushed the fix/resty-appstore-service-name branch from 673b888 to 68d9c3a Compare August 3, 2026 17:26
@joshua-seals
joshua-seals merged commit b8b4b58 into master Aug 3, 2026
@joshua-seals
joshua-seals deleted the fix/resty-appstore-service-name branch August 3, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants