Repository navigation
Merge master in develop - #111
Merged
Merged
Conversation
The de-Ambassador resty config resolves static upstreams (proxy_pass without an
nginx variable) at startup and refuses to boot if one is unresolvable. The host
comes from global.{appstore,ui}_service_name.
Default them based on how resty is deployed instead of hardcoding a prefix:
- Chart.IsRoot (resty deployed on its own) -> "appstore" / "ui"
- subchart of the umbrella (Release.Name=helx) -> "<release>-appstore" / "<release>-ui"
values.yaml leaves both null so the template default applies; an explicit
global.{appstore,ui}_service_name still overrides. Fixes the CrashLoopBackOff
seen deploying the umbrella (Service was "helx-appstore" but default was
"appstore") and works for any release name. sockets/airflow keep fixed
non-release-prefixed defaults.
Chart version 4.5.5 -> 4.5.6.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…name resty: default appstore_service_name to helx-appstore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.