Repository navigation
resty: add values-gated /artifact route to artifact-cache - #115
Merged
Merged
Conversation
De-Ambassador dropped the per-service ambassador Mapping "prefix: /artifact/ -> artifact-cache:8080", so envs that serve the helx-apps registry/specs (and browser-side app assets) from an in-cluster artifact cache lost /artifact and appstore's spec fetches 404'd -> empty app catalog (seen on OpenShift cdsr-stage, which is egress-restricted and can't reach GitHub). Add an optional location /artifact/ -> artifactCache.serviceName:port with the trailing-slash prefix strip (matches Ambassador's default rewrite). Gated on artifactCache.enabled (default false, so the umbrella/other envs are unaffected) with an optional auth_request gate via artifactCache.authenticate. resty 1.0.4 -> 1.0.5; umbrella 4.5.7 -> 4.5.8. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
De-Ambassador dropped the per-service ambassador Mapping "prefix: /artifact/ ->
artifact-cache:8080", so envs that serve the helx-apps registry/specs (and browser-side app assets) from an in-cluster artifact cache lost /artifact and appstore's spec fetches 404'd -> empty app catalog (seen on OpenShift cdsr-stage, which is egress-restricted and can't reach GitHub).
Add an optional location /artifact/ -> artifactCache.serviceName:port with the trailing-slash prefix strip (matches Ambassador's default rewrite). Gated on artifactCache.enabled (default false, so the umbrella/other envs are unaffected) with an optional auth_request gate via artifactCache.authenticate.
resty 1.0.4 -> 1.0.5; umbrella 4.5.7 -> 4.5.8.