Skip to content

Stable fallback to previously shown process - #2090

Open
fasterit wants to merge 9 commits into
htop-dev:mainfrom
fasterit:stable-fallback-to-previously-shown-process
Open

Stable fallback to previously shown process#2090
fasterit wants to merge 9 commits into
htop-dev:mainfrom
fasterit:stable-fallback-to-previously-shown-process

Conversation

@fasterit

Copy link
Copy Markdown
Member

Applies on top of the header-meter-clicks branch (PR #2085)

BenBE and others added 8 commits August 27, 2026 12:46
Co-authored-by: Benny Baumann <BenBE@geshi.org>
Assisted-by: Microsoft Copilot/Claude Sonnet 4.6
…icked

Idea from Hisham in htop-dev#2083 (comment)

Assisted-by: Microsoft Copilot/Claude Sonnet 4.6
…n the element after them (thr/kthr) are active
…hreads / container visibility

Applies on top of the header-meter-clicks branch (PR htop-dev#2085)

Assisted-by: OpenCode Zen
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 05dcc728-56ef-4c9e-8f39-34aa96a5a845

📥 Commits

Reviewing files that changed from the base of the PR and between f310163 and f530113.

📒 Files selected for processing (1)
  • ScreenManager.c

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The PR adds span-aware integer header dimensions and header meter hit-testing. It adds click callbacks to meters and forwards header mouse clicks through ScreenManager. The Tasks meter toggles thread visibility from text-mode count clicks. Table selection state is preserved and restored across visibility-driven rescans. Existing toggle actions also preserve selection before rescanning.

Poem

Columns find their measured place
A click now follows a precise trace
Thread counts turn their setting bright
Rows return through rebuild night
Selections stay where they belong

Merge Risk: ⚪ Minimal · up to f5301

The change preserves the selected process across visibility-triggered rescans and adds localized header click handling. No actionable merge-blocking risk remains at the current head; it is merge-ready after normal checks and review.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cafe07af-fea9-41a4-8170-abd5b2c3cc1f

📥 Commits

Reviewing files that changed from the base of the PR and between 19fc8c1 and f310163.

📒 Files selected for processing (9)
  • Action.c
  • Header.c
  • Header.h
  • HeaderLayout.h
  • Meter.h
  • ScreenManager.c
  • Table.c
  • Table.h
  • TasksMeter.c

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Comment thread ScreenManager.c Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants