Skip to content

[ci] fix public api check and add tests - #1259

Open
sayakpaul wants to merge 1 commit into
mainfrom
fix-public-api-checks
Open

sayakpaul wants to merge 1 commit into
mainfrom
fix-public-api-checks

Conversation

@sayakpaul

Copy link
Copy Markdown
Member

https://github.com/huggingface/kernels-community/actions/runs/37809295964/job/113421669084?pr=1210 shouldn't have failed.

This PR improves the public API checks:

  • Ensures that, in a scenario where positional arguments are being added without changing defaults of existing arguments don't lead to errors.
  • Better error messaging on our CI.
  • Adds a test suite and includes it in our CI because public API checks are important.

@sayakpaul
sayakpaul requested a review from drbh October 22, 2026 06:08
@github-actions github-actions Bot added the chore Version bumps, releases, misc maintenance label Oct 22, 2026

@danieldk danieldk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice improvement!

@pytest.mark.parametrize(
"old,new,expected",
[
pytest.param(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have all these testsed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Version bumps, releases, misc maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants