Pin the doc-builder workflows to their pre-#648 revisions - #650
Merged
tomaarsen merged 1 commit intoSep 4, 2026
Merged
Conversation
The newer doc-builder reusable workflows do a light install when the package has a mock-deps registry entry, installing the package with --no-deps plus only the packages that entry lists as real. The setfit entry lists nothing as real, so every docs build since huggingface#648 fails with ModuleNotFoundError for pandas. The previous revisions do a full [dev] install and still work.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Heads up, this PR was AI-generated and human-reviewed.
Pull Request overview
Details
Every docs build since #648 fails, including the ones for #649 and the v1.2.0 release commit, while every build before it passed. The bump moved the reusable workflows past huggingface/doc-builder#801, which introduced a light install: when doc-builder has a mock-deps registry entry for the package, the workflow installs the package with
--no-depsand then only the packages that the entry lists asreal:. The entry for setfit only lists packages to mock and no real ones, sodatasets,pandas,transformers,huggingface_hubandevaluateare never installed and importing setfit fails withModuleNotFoundError: No module named 'pandas'.This PR pins the four workflows back to the revisions in use before #648, which do a full
[dev]install. Those revisions built, uploaded and commented on the #649 docs earlier today, so they are known to work end to end.Two follow-ups. Dependabot will propose the same bump again, so its PRs for
huggingface/doc-buildershould be closed (or ignored independabot.yml) until the registry is fixed. The proper fix is addingreal:entries for setfit's dependencies tosrc/doc_builder/mock_deps/setfit.txtin doc-builder, after which the bump can be accepted.