Repository navigation
fix(iframe): extract src from pasted embed code - #384
Merged
Merged
Conversation
Pasting a full embed snippet (e.g. Google Maps "Copy HTML") stored the whole <iframe> tag as the src, so the frame loaded a relative 404 page. The input is now reduced to the src url and HTML entities are decoded. Also resolve YouTube shorts/live links and Vimeo links to embed urls.
|
@M4rdine is attempting to deploy a commit to the Gia Hung's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you paste the embed code from Google Maps ("Share > Embed a map > Copy HTML") into the iframe dialog, the whole
<iframe ...>string ends up insrc. The browser treats it as a relative path and the frame shows a 404 page. Same thing happens with HTML-escaped input (<iframe src="...) or urls with&.getServiceSrcnow reduces the input to the url before detecting the service:<iframe>tag, uses itssrc(double, single or no quotes)Since the YouTube/Google Maps/etc. detection runs after that, a pasted YouTube embed snippet still gets converted as before.
While testing I also hit two link formats that weren't recognized:
youtube.com/shorts/IDandyoutube.com/live/ID(added to the existing regex)vimeo.com/IDandplayer.vimeo.com/video/ID(newvimeoservice, resolves toplayer.vimeo.com/video/ID)Both the toolbar dialog and the iframe bubble go through
getServiceSrc, so they both get the fix. Content that was already saved with a broken src isn't migrated.Tests
Added
tests/iframe-utils.test.ts(node:test, same setup as the other tests):pnpm exec esno --test tests/iframe-utils.test.tspnpm lint,pnpm fmt:checkon the changed files,pnpm type-check,pnpm test:typesandpnpm build:libpass.