Repository navigation
fix(snapshot): preserve visible controls within tree budgets on all platforms - #145
Merged
Merged
Conversation
iFurySt
marked this pull request as ready for review
November 2, 2026 14:21
Owner
Author
|
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large lists can exhaust a snapshot's node budget before later dialog buttons are visited. This change prioritizes visible controls and ordinary UI regions across macOS AX, Windows UIA and Linux AT-SPI, then renders the selected graph in its original order with valid action indexes and ancestor paths.
The default 1200-node limit stays unchanged. Candidate discovery is separately bounded, duplicate references and cycles cannot bypass it, and truncated snapshots carry an explicit notice. macOS respects AXVisibleChildren; Linux supplements SHOWING with viewport geometry; Windows batches UIA properties per snapshot to avoid the 30-second timeout found by the real WPF test.
Validation:
Reproducible commands and limits: docs/tree-budget.md. A slow provider's individual API call is still outside the candidate-count bound; extremely small budgets cannot guarantee every control.
Final-head Windows CI passed. Its first attempt timed out while starting the pre-existing WPF fixture, before native MCP was launched; the unchanged commit passed on retry.