Skip to content

Dashboard: fail on datasets without rows, guard clears - #459

Merged
radiken merged 2 commits into
masterfrom
alan/dashboard-fixes
Nov 17, 2026
Merged

radiken merged 2 commits into
masterfrom
alan/dashboard-fixes

Conversation

@radiken

@radiken radiken commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

A create, update or reprocess that leaves a dataset without rows now fails and names it. A failed or empty fetch is no longer stored as [], so the next reprocess fetches it again. Clear-all is gone, single clears are refused past retention, and VM queries refuse partial answers. The 120 s timeout is dropped because vmselect cuts queries off at its default 30 s.

…M timeout

A create whose datasets fetched no rows now returns 502 and removes the
experiment. process_experiment always returned the id, so the old rollback
never ran.

The clear-all endpoint is gone, and a single clear is refused once the
dataset's window is past the 6-month retention, since no reprocess could
fetch it again.

The dashboard's VM queries wait 120 s instead of 30 s; cold queries on 1k-node
runs took longer than 30 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…process

A fetch that fails or returns nothing no longer stores [], which counted as
fetched and was never retried; the next reprocess fetches it again. Update
and reprocess now fail with the datasets that have no rows, as create does
(update's rollback never ran). VM queries refuse partial answers, since
stored rows are final. The 120 s VM timeout is dropped: vmselect caps
queries at its default 30 s, so it had no effect.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@radiken radiken changed the title Dashboard: fail a create on empty datasets, guard clears, raise the VM timeout Dashboard: fail on datasets without rows, guard clears Nov 17, 2026
@radiken radiken self-assigned this Nov 17, 2026
@radiken radiken added the enhancement New feature or request label Nov 17, 2026
@radiken radiken linked an issue Nov 17, 2026 that may be closed by this pull request
@radiken
radiken marked this pull request as ready for review November 17, 2026 12:14
@radiken
radiken merged commit 54b4742 into master Nov 17, 2026
2 checks passed
@radiken
radiken deleted the alan/dashboard-fixes branch November 17, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

General tooling (recurring)

2 participants