Repository navigation
Dashboard: fail on datasets without rows, guard clears - #459
Merged
Merged
Conversation
…M timeout A create whose datasets fetched no rows now returns 502 and removes the experiment. process_experiment always returned the id, so the old rollback never ran. The clear-all endpoint is gone, and a single clear is refused once the dataset's window is past the 6-month retention, since no reprocess could fetch it again. The dashboard's VM queries wait 120 s instead of 30 s; cold queries on 1k-node runs took longer than 30 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…process A fetch that fails or returns nothing no longer stores [], which counted as fetched and was never retried; the next reprocess fetches it again. Update and reprocess now fail with the datasets that have no rows, as create does (update's rollback never ran). VM queries refuse partial answers, since stored rows are final. The 120 s VM timeout is dropped: vmselect caps queries at its default 30 s, so it had no effect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
radiken
marked this pull request as ready for review
November 17, 2026 12:14
AlbertoSoutullo
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A create, update or reprocess that leaves a dataset without rows now fails and names it. A failed or empty fetch is no longer stored as
[], so the next reprocess fetches it again. Clear-all is gone, single clears are refused past retention, and VM queries refuse partial answers. The 120 s timeout is dropped because vmselect cuts queries off at its default 30 s.