Repository navigation
crc32 is overridden by another library when using bundler #38
Description
I inserted the same input, but I got different bitmap on Linux and Mac.
I ran the following code.
- test.rb
require 'cbloomfilter'
bf = CBloomFilter.new(16, 1, 7, 1)
puts "m #{bf.m}"
puts "k #{bf.k}"
puts "b #{bf.b}"
bf.insert 'a'
puts "bitmap: #{bf}"
- Result on Linux
$ bundle exec ruby test.rb
m 16
k 1
b 1
bitmap: 1000000000000000
- Result on Mac
m 16
k 1
b 1
bitmap: 0000000000000100
I added rb_warn into crc32 to check if the function crc32 in your gem is called.
... snip ...
#include "crc32.h"
unsigned int crc32(unsigned int crc, char *buf, int len) {
while (len > 0) {
crc = crc_table[(crc ^ *buf) & 0xff] ^ (crc >> 8);
rb_warn("crc: %d\n", crc);
--len;
++buf;
}
return crc;
}
And I ran test.rb with bundler, but I got no warning output by rb_warn.
From this result, maybe crc32 in your gem is not called.
I also ran test.rb without bundler specifying LOAD_PATH explicitly.
$ ruby -I./vendor/bundle/ruby/2.2.0/bundler/gems/bloomfilter-rb-8c9da9516796/ext/cbloomfilter test.rb
m 16
k 1
b 1
test.rb:9: warning: crc: -1529756563
bitmap: 0000000000000100
The waning output came out and I got the same bitmap as that on Mac.
So crc32 seems to be overridden by another library when using bundler on Linux.
Activity
igrigorik commentedon Jul 26, 2015
Huh, well that's a fun one. Thanks for tracking this down... /me scratches head, not quite sure what's going here.
I guess we could/should the built-in method: http://ruby-doc.org/stdlib-1.9.3/libdoc/zlib/rdoc/Zlib.html#method-c-crc32
n-nishizawa commentedon Jul 28, 2015
Thank you so much for your reply!!
I have no idea why this strange thing happens too...
In my investigation,
Zlib.crc32might be used on Linux with bundler.Because the index based on
Zlib.crc32corresponds to this gems's bit field.To fix it, I think there are two options.
One is to rename
crc32in your gem to prevent the name conflict.Another is to use builtin crc32 such as
Zlib.crc32like your suggestion.igrigorik commentedon Aug 2, 2015
We should update the code to use the provided crc32 implementation.. no reason to duplicate it.