Remove 20 ForMathlib declarations now in mathlib/core; rename lsbs → setWidth - #3
Open
ibrahimmian36 wants to merge 1 commit into
Open
ibrahimmian36 wants to merge 1 commit into
ibrahimmian36 wants to merge 1 commit into
Conversation
…me lsbs->setWidth at use sites Verified against mathlib c1e30e17 (the lake-manifest revision) on leanprover/lean4:v4.30.0-rc2. One proof adjustment disclosed: weight_and_le's original proof relied on lsbs being opaque to simp; the setWidth version instantiates the induction hypothesis and closes with omega. Evidence that every deleted statement is derivable from mathlib/core alone: leanquantum-triage/evidence/Redundant.lean.
Member
|
This looks good to me. @f64u, okay to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are all provided by mathlib or Lean core at the pinned toolchain (
v4.30.0-rc2, mathlibc1e30e17). Builds green.Proofs re-deriving each deleted statement from mathlib alone, plus a triage of the whole
ForMathlib/directory: https://github.com/ibrahimmian36/leanquantum-triageOne proof needed a small change:
weight_and_lerelied onlsbsbeing opaque tosimp; thesetWidthversion uses the IH andomega.