Skip to content

Consider opening the API #27

Description

@xrstf

I'm trying to work around issue #23. For this, I tried to simply use a custom storage implementation that has my patch (LOCK_SH) in it.

Unfortunately, nearly everything inside the Session middleware is private, so for making a simple patch to lock() I have to copy nearly everything. Not just because most of the stuff is private, but because most methods directly access the properties (instead of using a getter).

This makes it extremely hard and ugly to subclass AiP. I would suggest using protected more often and/or introducing some getters where properties must be private.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions