fix: Removes filtering for expandable queries - #3934
Open
awildturtok wants to merge 1 commit into
Open
Conversation
awildturtok
force-pushed
the
fix/show-editorv2-queries
branch
2 times, most recently
from
August 5, 2026 14:15
29db9d5 to
94ca1ee
Compare
thoniTUB
requested changes
Aug 6, 2026
Comment on lines
+50
to
+69
| import jakarta.inject.Inject; | ||
| import jakarta.servlet.http.HttpServletRequest; | ||
| import jakarta.validation.Validator; | ||
| import jakarta.ws.rs.BadRequestException; | ||
| import jakarta.ws.rs.core.Response; | ||
| import jakarta.ws.rs.core.UriBuilder; | ||
| import lombok.AllArgsConstructor; | ||
| import lombok.NoArgsConstructor; | ||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
| import java.text.NumberFormat; | ||
| import java.time.LocalDate; | ||
| import java.util.*; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.function.Consumer; | ||
| import java.util.function.Predicate; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
| import java.util.stream.Stream; | ||
|
|
Collaborator
There was a problem hiding this comment.
In meinem Intellij ist die Sortierung auch wieder kaputt. Kannst es bitte einmal checken und ggf anpassen sodass die offiziellen (java/jakarta) wieder nachoben kommen
| return switch (query) { | ||
| case ConceptQuery ignored -> true; | ||
| case SecondaryIdQuery ignored -> true; | ||
| case null, default -> false; |
Collaborator
There was a problem hiding this comment.
Bitte einen Kommentar ran machen, wenn null das eigentlich ein Fehlerfall ist. Oder ist das legitim?
Collaborator
Author
There was a problem hiding this comment.
ja guter Punkt, null kann vmtl gar nicht passieren
Comment on lines
+135
to
+136
| QUERY_ID_8 = createExecutionId(DATASET_0, "9"); | ||
| QUERY_ID_9 = createExecutionId(DATASET_0, "10"); |
Collaborator
There was a problem hiding this comment.
Suggested change
| QUERY_ID_8 = createExecutionId(DATASET_0, "9"); | |
| QUERY_ID_9 = createExecutionId(DATASET_0, "10"); | |
| QUERY_ID_8 = createExecutionId(DATASET_0, "8"); | |
| QUERY_ID_9 = createExecutionId(DATASET_0, "9"); |
Collaborator
Author
There was a problem hiding this comment.
ah, danke. Musste den PR neu machen, hab das übersehen
| }})); | ||
| }}, DATASET_0 | ||
| ), // included, but secondaryId-Query | ||
| mockManagedSecondaryIdQueryFrontEnd(USERS[1], QUERY_ID_8, DONE, new CQConcept(), DATASET_0), // not-included, wrong structure |
Collaborator
There was a problem hiding this comment.
Warum hast du den Case gekickt, der ist doch jetzt darstellbar,oder?
Collaborator
Author
There was a problem hiding this comment.
Weil er keinen Sonderfall mehr darstellt
awildturtok
force-pushed
the
fix/show-editorv2-queries
branch
from
August 6, 2026 12:20
94ca1ee to
967afcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As that hides editorv2 queries from users, which they can actually use in editorv2