Skip to content

Added the material for XGBoost optimization - #30

Open
bbhattar wants to merge 10 commits into
intel:mainfrom
bbhattar:xgboost
Open

Added the material for XGBoost optimization#30
bbhattar wants to merge 10 commits into
intel:mainfrom
bbhattar:xgboost

Conversation

@bbhattar

Copy link
Copy Markdown

Added the materials for XGBoost optimization. Please review and give me your feedback.

Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
@rsiyer-intel
rsiyer-intel requested a review from adgubrud May 18, 2026 19:29
@rsiyer-intel

Copy link
Copy Markdown
Collaborator

Since the latest changes still have perf data, it cannot be approved till we get perf claim pre-requisites fulfilled.

Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated

@david-cortes-intel david-cortes-intel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: this guide says 'xgboost', but it is limited to predictions/inference, while a similar guide could also be done for training, covering details like threading, hyperparameters to try, and similar.

Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated

@razdoburdin razdoburdin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update installation instructions and consider switching to the actual versions of the software.

Comment thread software/xgboost/README.md Outdated
…-learn, removing memory allocator section, and clarifying the scope to include all 3 methods
@bbhattar

Copy link
Copy Markdown
Author

Since the latest changes still have perf data, it cannot be approved till we get perf claim pre-requisites fulfilled.

@rsiyer-intel Updated the doc with PDT approved data

@bbhattar

Copy link
Copy Markdown
Author

please update installation instructions and consider switching to the actual versions of the software.

Done and done

Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md
…e mention of undefined default, removed unnecessary symmetric tree mention
Comment thread software/xgboost/README.md Outdated
Comment thread software/xgboost/README.md Outdated
daal4py's vectorized tree traversal is [backend-bound](https://www.intel.com/content/www/us/en/docs/vtune-profiler/cookbook/2023-0/top-down-microarchitecture-analysis-method.html) — whether the bottleneck is core execution units or memory bandwidth, adding hyperthreads increases resource contention on the shared physical core, harming performance.

> **Cloud instance note:** On AWS and GCP, each vCPU does not necessarily map to a hyperthread. Smaller instance sizes use soft partitioning, so you may not know how many physical cores vs. hyperthreads you are getting. The guidance below applies most directly to bare-metal or dedicated-host instances where the physical topology is known. On shared instances, benchmark with your specific instance size to determine whether pinning provides a benefit.
> **Cloud instance note:** Depending on CSP deployment choices, smaller instance sizes may not expose how many physical cores vs. hyperthreads are provided. The guidance below applies most directly to bare-metal or dedicated-host instances where the physical topology is known. On shared instances, benchmark with your specific instance size to determine whether pinning provides a benefit.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That information is always retrievable at runtime, through tools like lscpu or python-level tools like joblib.

@adgubrud adgubrud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the requested changes! A couple of small details to resolve.

Comment thread README.md
- [MySQL & PostgreSQL](software/mysql-postgresql/README.md)
- [R (Rlang / Rstats)](software/R/README.md)
- [scikit-learn](software/scikit-learn/README.md)
- [XGBoost](software/xgboost/README.ms)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just recently alphabetized the TOC. Can you please move this entry to be in alphabetical order?

Comment thread README.md
- [MySQL & PostgreSQL](software/mysql-postgresql/README.md)
- [R (Rlang / Rstats)](software/R/README.md)
- [scikit-learn](software/scikit-learn/README.md)
- [XGBoost](software/xgboost/README.ms)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is broken

Suggested change
- [XGBoost](software/xgboost/README.ms)
- [XGBoost](software/xgboost/README.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants