Repository navigation
feat(chip): sync the ios theme with iOS 17 #31780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
14ce353
fix(chip): match the ios font size on next
thetaPC 0c06952
fix(chip): use the iOS capsule shape for ios chips
thetaPC e8eb7c5
fix(chip): use the iOS typography and sizes for ios chips
thetaPC fa673e4
fix(chip): use the iOS icon spacing for ios chips
thetaPC 49d0026
fix(chip): use the iOS tinted background for colored ios chips
thetaPC d1ddf65
fix(chip): match the ios button disabled opacity for ios chips
thetaPC 51d7a5c
chore(chip): remove the ios chip comments
thetaPC 0ee14d6
chore(chip): update ios snapshots
thetaPC 8afc7db
Merge remote-tracking branch 'origin/chip-md-sync' into chip-ios-sync
thetaPC 62f754c
fix(chip): inset the avatar in small ios chips
thetaPC c749312
docs(chip): list the ios icon and avatar sizes to revert to
thetaPC 6656f18
chore(chip): update ios snapshots
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+70 Bytes
(100%)
.../basic/avatar.e2e.ts-snapshots/avatar-chip-diff-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-76 Bytes
(97%)
...basic/avatar.e2e.ts-snapshots/avatar-chip-diff-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+45 Bytes
(100%)
.../basic/avatar.e2e.ts-snapshots/avatar-chip-diff-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-91 Bytes
(98%)
...chip/test/a11y/chip.e2e.ts-snapshots/chip-scale-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-428 Bytes
(93%)
...hip/test/a11y/chip.e2e.ts-snapshots/chip-scale-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-365 Bytes
(95%)
...chip/test/a11y/chip.e2e.ts-snapshots/chip-scale-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+26 Bytes
(100%)
...test/basic/chip.e2e.ts-snapshots/chip-descender-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+63 Bytes
(100%)
...est/basic/chip.e2e.ts-snapshots/chip-descender-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+190 Bytes
(110%)
...test/basic/chip.e2e.ts-snapshots/chip-descender-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+127 Bytes
(100%)
.../basic/chip.e2e.ts-snapshots/chip-outline-color-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+438 Bytes
(110%)
...basic/chip.e2e.ts-snapshots/chip-outline-color-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+254 Bytes
(110%)
.../basic/chip.e2e.ts-snapshots/chip-outline-color-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+40 Bytes
(100%)
...p/test/basic/chip.e2e.ts-snapshots/chip-outline-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+92 Bytes
(110%)
.../test/basic/chip.e2e.ts-snapshots/chip-outline-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+100 Bytes
(110%)
...p/test/basic/chip.e2e.ts-snapshots/chip-outline-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+26 Bytes
(100%)
...st/basic/chip.e2e.ts-snapshots/chip-solid-color-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+332 Bytes
(110%)
...t/basic/chip.e2e.ts-snapshots/chip-solid-color-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+196 Bytes
(110%)
...st/basic/chip.e2e.ts-snapshots/chip-solid-color-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-23 Bytes
(99%)
...hip/test/basic/chip.e2e.ts-snapshots/chip-solid-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-84 Bytes
(96%)
...ip/test/basic/chip.e2e.ts-snapshots/chip-solid-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-50 Bytes
(98%)
...hip/test/basic/chip.e2e.ts-snapshots/chip-solid-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-31 Bytes
(98%)
...hip/test/basic/chip.e2e.ts-snapshots/chip-solid-ios-rtl-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-44 Bytes
(98%)
...ip/test/basic/chip.e2e.ts-snapshots/chip-solid-ios-rtl-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-20 Bytes
(99%)
...hip/test/basic/chip.e2e.ts-snapshots/chip-solid-ios-rtl-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+9 Bytes
(100%)
...ip/test/hue/chip.e2e.ts-snapshots/chip-hue-bold-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.86 KB
(96%)
...p/test/hue/chip.e2e.ts-snapshots/chip-hue-bold-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.64 KB
(100%)
...ip/test/hue/chip.e2e.ts-snapshots/chip-hue-bold-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-794 Bytes
(98%)
.../test/hue/chip.e2e.ts-snapshots/chip-hue-subtle-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.42 KB
(94%)
...test/hue/chip.e2e.ts-snapshots/chip-hue-subtle-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+983 Bytes
(100%)
.../test/hue/chip.e2e.ts-snapshots/chip-hue-subtle-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+11 Bytes
(100%)
...st/shape/chip.e2e.ts-snapshots/chip-rectangular-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-54 Bytes
(97%)
...t/shape/chip.e2e.ts-snapshots/chip-rectangular-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+92 Bytes
(100%)
...st/shape/chip.e2e.ts-snapshots/chip-rectangular-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-51 Bytes
(96%)
...hip/test/shape/chip.e2e.ts-snapshots/chip-round-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-51 Bytes
(96%)
...ip/test/shape/chip.e2e.ts-snapshots/chip-round-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-45 Bytes
(97%)
...hip/test/shape/chip.e2e.ts-snapshots/chip-round-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+17 Bytes
(100%)
...chip/test/shape/chip.e2e.ts-snapshots/chip-soft-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+67 Bytes
(110%)
...hip/test/shape/chip.e2e.ts-snapshots/chip-soft-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+0 Bytes
(100%)
...chip/test/shape/chip.e2e.ts-snapshots/chip-soft-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+75 Bytes
(110%)
...test/size/chip.e2e.ts-snapshots/chip-size-large-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+86 Bytes
(110%)
...est/size/chip.e2e.ts-snapshots/chip-size-large-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+88 Bytes
(110%)
...test/size/chip.e2e.ts-snapshots/chip-size-large-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+14 Bytes
(100%)
...test/size/chip.e2e.ts-snapshots/chip-size-small-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+64 Bytes
(110%)
...est/size/chip.e2e.ts-snapshots/chip-size-small-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+75 Bytes
(110%)
...test/size/chip.e2e.ts-snapshots/chip-size-small-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+22 Bytes
(100%)
...test/states/chip.e2e.ts-snapshots/chip-disabled-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+71 Bytes
(100%)
...est/states/chip.e2e.ts-snapshots/chip-disabled-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+271 Bytes
(110%)
...test/states/chip.e2e.ts-snapshots/chip-disabled-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+131 Bytes
(110%)
.../test/states/chip.e2e.ts-snapshots/chip-focused-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+4 Bytes
(100%)
...test/states/chip.e2e.ts-snapshots/chip-focused-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+160 Bytes
(100%)
.../test/states/chip.e2e.ts-snapshots/chip-focused-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ export const global = { | |
| export const components = { | ||
| chip: { | ||
| font: { | ||
| size: 14, | ||
| size: 15, | ||
| }, | ||
| }, | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outline chips come out 2px taller than solid ones now,
30pxvs28pxon large and26pxvs24pxon small, so a row mixing the two won't line up. The padding plus the line height already fills the min-height, so the outline's border can only add to it. With3pxhere and2px(--ion-spacing-xxxs) onsmall, every fill comes out28pxand24px, and the solid, size, shape and avatar screenshots don't change.The one catch is that solid chips at large font sizes get 2px shorter too (
chip-scalegoes from38pxto36px). If you'd rather avoid that, I think taking the border width off the outline chip's padding inchip.scsswould work instead. Either way, the padding in the breaking changes entry would need updating.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Shane's outline height comment. The md PR has the same bug, so it'd be good to fix both the same way. If the outline border comes off the padding in
chip.scss, it covers md and ios at once and the ios padding can stay as it is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the md PR with adfb6c9, which takes the outline's border width off its vertical padding in
chip.scss. It's merged up here, and ios outline chips are now 28px and 24px like the solid ones (6656f18 updates the snapshots).That keeps the ios padding as it is, so solid chips at large font sizes don't get shorter, and the BREAKING entry stays the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done that way in adfb6c9 on the md PR, so it covers md and ios at once. The ios snapshots are updated in 6656f18.