Add SetBuilder for batched gNMI Set operations - #445
Merged
Conversation
felix-kaestner
commented
Jul 15, 2026
felix-kaestner
force-pushed
the
refactor/gnmiext
branch
2 times, most recently
from
July 16, 2026 08:41
9b6aad6 to
b4aa0bc
Compare
felix-kaestner
force-pushed
the
refactor/gnmiext
branch
from
July 16, 2026 09:12
498fa84 to
1c4072a
Compare
felix-kaestner
force-pushed
the
refactor/gnmiext
branch
2 times, most recently
from
July 24, 2026 15:35
3d387c8 to
e274257
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
felix-kaestner
force-pushed
the
refactor/gnmiext
branch
2 times, most recently
from
July 31, 2026 14:42
d29855e to
19fa61e
Compare
felix-kaestner
commented
Aug 4, 2026
felix-kaestner
force-pushed
the
refactor/gnmiext
branch
2 times, most recently
from
August 10, 2026 14:15
e11e327 to
93fb9da
Compare
IvoGoman
reviewed
Aug 11, 2026
IvoGoman
left a comment
IvoGoman
left a comment
There was a problem hiding this comment.
Metric namespace would be nice to have. Comments about readability are up to you.
felix-kaestner
force-pushed
the
refactor/gnmiext
branch
from
August 11, 2026 14:09
93fb9da to
8f12c6a
Compare
IvoGoman
approved these changes
Aug 11, 2026
Introduce a SetBuilder type that accumulates update, patch, and delete operations to be executed as a single gNMI Set RPC via the new Client.Do method. This allows atomic multi-operation commits without multiple round-trips to the device. An optional Limit method controls the maximum number of operations per SetRequest, splitting into multiple RPCs when set. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Register three metrics with controller-runtime's metrics registry: - gnmi_operations_total: per-operation counter with target, rpc, operation, path, and status labels - gnmi_rpc_duration_seconds: histogram of actual gNMI RPC latency - gnmi_operations_skipped_total: counter for diff-skipped operations Operation metrics are derived from the SetRequest after the RPC completes, ensuring the status label reflects the actual outcome. Add WithTarget option to associate a device address with metrics for correlating slow-responding devices. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Add go:generate directive to produce a ClientMock using moq with panic-on-unset and call-tracking resets. Register moq as a Go 1.24+ tool dependency in go.mod. Replace the hand-rolled MockClient in the IOS-XR provider tests with the generated gnmiext.ClientMock. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
refactor/gnmiext
branch
from
August 11, 2026 15:02
8f12c6a to
bb46d5a
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a SetBuilder type that accumulates update, patch, and delete operations to be executed as a single gNMI Set RPC via the new Client.Do method. This allows atomic multi-operation commits without multiple round-trips to the device.
An optional Limit method controls the maximum number of operations per SetRequest, splitting into multiple RPCs when set.