fix(orderbook): restore precision controls for native portal menus - #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binance now renders orderbook precision choices in a Select portal under
body, leaving the userscript's precision shortcuts empty. Resolve that portal through the native control's stable listbox identity, read its current option markup, and show an explicit loading or unavailable state when options cannot be read. This releases orderbook userscript2.7.204.The DOM adapter requires a unique control-owned listbox ID and consistent React owner branches. Precision reads remain independent of menu ownership, asynchronous snapshots are revalidated after cleanup, and cleanup closes the captured trigger without selecting an option. The existing scoped observer and bounded loading behavior are retained.
Validation:
npm test: 946 passed.npm run test:ui: 73 passed, including native portal bootstrap, exact option selection, control replacement, symbol switching, and visual snapshots.git diff --checkpassed.2.7.203with zero shortcuts, then passed on2.7.204.The browser fixture now matches the current native portal contract. A pre-existing test observation race for the 140 ms multiplier press feedback is also fixed by collecting attribute transitions before the click; production feedback timing is unchanged.
Strategy27 and Strategy29 also import the shared localization module, so their generated artifacts are rebuilt as
0.6.1and0.5.2to include the same three copy entries. Their source changes are metadata only. The full test suite and both Strategy29 coexistence browser scenarios cover the final artifacts.