Skip to content

fix(orderbook): restore precision controls for native portal menus - #287

Merged
jackhai9 merged 3 commits into
mainfrom
codex/fix-orderbook-precision-portal
Sep 12, 2026
Merged

fix(orderbook): restore precision controls for native portal menus#287
jackhai9 merged 3 commits into
mainfrom
codex/fix-orderbook-precision-portal

Conversation

@jackhai9

@jackhai9 jackhai9 commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Binance now renders orderbook precision choices in a Select portal under body, leaving the userscript's precision shortcuts empty. Resolve that portal through the native control's stable listbox identity, read its current option markup, and show an explicit loading or unavailable state when options cannot be read. This releases orderbook userscript 2.7.204.

The DOM adapter requires a unique control-owned listbox ID and consistent React owner branches. Precision reads remain independent of menu ownership, asynchronous snapshots are revalidated after cleanup, and cleanup closes the captured trigger without selecting an option. The existing scoped observer and bounded loading behavior are retained.

Validation:

  • npm test: 946 passed.
  • npm run test:ui: 73 passed, including native portal bootstrap, exact option selection, control replacement, symbol switching, and visual snapshots.
  • Build, syntax, metadata/release contract, and git diff --check passed.
  • The new bootstrap browser regression failed on 2.7.203 with zero shortcuts, then passed on 2.7.204.
  • Executing the actual new DOM adapter on the live Binance page read all five current native options and restored the closed menu without changing precision.

The browser fixture now matches the current native portal contract. A pre-existing test observation race for the 140 ms multiplier press feedback is also fixed by collecting attribute transitions before the click; production feedback timing is unchanged.

Strategy27 and Strategy29 also import the shared localization module, so their generated artifacts are rebuilt as 0.6.1 and 0.5.2 to include the same three copy entries. Their source changes are metadata only. The full test suite and both Strategy29 coexistence browser scenarios cover the final artifacts.

@jackhai9
jackhai9 merged commit 8ca6458 into main Sep 12, 2026
2 checks passed
@jackhai9
jackhai9 deleted the codex/fix-orderbook-precision-portal branch September 12, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant