Skip to content

fix(strategy27): retain compound candidate history through recovery #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackhai9 merged 1 commit into from
Sep 12, 2026
Merged

fix(strategy27): retain compound candidate history through recovery #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 25 additions & 15 deletions docs/binance-strategy27-events-development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ V10 live projection. The VPS remains the only market-data and event-analysis
authority. The userscript opens no Binance market-data WebSocket, uses no
Binance API key, and does not recalculate the four force groups.

Version 0.6.1 retains this installation's private gateway configuration and
Version 0.6.2 retains this installation's private gateway configuration and
provides a shared read-only transport. Strategy29 owns its own summary panel,
lifecycle and panel position. The existing `strategy27GatewayOrigin` and
`strategy27GatewayAuthSecret` storage keys remain the single credential source;
Expand Down Expand Up @@ -148,8 +148,8 @@ message arrives. Compound candidates restore only missing parts of their
icon/label pair, preserving the original slot and surviving entity IDs. Each
record shares one in-flight repair across timer and message callbacks. Cleanup
skips IDs proven absent, while native removal failures still stop the owning job.
Manual clear, context changes and display retention eviction invalidate ordinary
repair ownership; compound resets also invalidate their own repair ownership;
Manual clear, context changes and display retention eviction invalidate owned
repairs; terminal job failures suspend new presentation and repair;
late-created entities are removed instead of resurrecting retired records.
Reconciliation does not refresh retention timestamps. Drawings remain transient
and use `disableSave: true`, but a full page reload requests a bounded display
Expand All @@ -165,7 +165,7 @@ ADR 032 in CorsairQuant owns the server-side rule and transport contract. The
browser does not reconstruct candidates from ordinary events or recalculate
market evidence. The client, lifecycle, panel, native chart layer and optional-job
controller are wired into the entrypoint and tested together. The source and
generated install artifact are version 0.6.1 with identical metadata headers.
generated install artifact are version 0.6.2 with identical metadata headers.
The generated artifact passes syntax, release-contract and isolated execution
checks, including candidate delivery, paired entities, clear and context stop.
Binance operator-page validation remains outstanding. Server/gateway rollout
Expand All @@ -176,8 +176,9 @@ Do not treat source unit tests or the panel fixture as deployment evidence.

- The compound client has a separate cursor for
`/v1/strategy27/compound-candidates`. Non-JSON HTTP 404 disables only that
client until restart. Validated HTTP 503 `compound_unavailable` and
`redis_unavailable` clear only compound state and retry after two seconds.
client until restart while retaining verified history. Validated HTTP 503
`compound_unavailable` and `redis_unavailable` reset compound protocol state,
preserve verified history, and retry bootstrap after two seconds.
Typed request transport failures retain the cursor. Other contract failures
are not retried. Cancellation is checked after request and async validation
boundaries so a stopped context cannot publish a late status.
Expand All @@ -200,8 +201,11 @@ Do not treat source unit tests or the panel fixture as deployment evidence.
from the original decision time. Exact replay does not refresh that age or
create another marker. Heartbeats do not clear history. Epoch changes require
`stream_state`; symbol filtering permits increasing sequence gaps, not
regressions. Capacity eviction follows decision time and candidate ID with a
monotonic cutoff so old replay cannot resurrect evicted observations.
regressions. Protocol resets and bootstrap preserve accepted immutable candidate
IDs, including records suppressed by manual clear. Replayed candidates do not
redraw or republish them. Capacity eviction follows decision time and candidate
ID with a monotonic cutoff that survives protocol resets, so old replay cannot
resurrect evicted observations. Full context retirement clears this ownership.
- Base rule identity is `(family, direction, profile_id)`. Reinforcement also
includes `parent_candidate_id` in its displayed lineage identity. Each
occurrence has its own candidate ID; different rules or parents at the same
Expand All @@ -213,20 +217,26 @@ Do not treat source unit tests or the panel fixture as deployment evidence.
- The compound controller owns its request cancellation and terminal error
boundary. It constructs its chart layer only on the first accepted candidate,
so a missing compound chart capability cannot fail ordinary startup. A stream
state clears compound views without erasing the newly accepted epoch/sequence;
a gateway reset or explicit unavailability resets both lifecycle and view.
state accepts the new epoch/sequence without clearing verified candidates.
Gateway resets, unavailability and bootstrap also preserve their native entity
IDs, slots and panel history, including candidates absent from a newer snapshot.
Manual clear preserves replay bookkeeping but invalidates pending presentation.
Age eviction also invalidates a pending draw, and a second age check runs after
drawing before publication to the panel. The existing context timer calls
`reconcile()`, which prunes before repairing missing entities; there is no
second timer. Route/interval changes and disappearance
of the visible chart stop both clients before destroying the shared panel.
The clear menu clears both views without restarting either client.
- Native cleanup attempts every owned entity once and aggregates failures.
Cleanup failure stops only the compound job, clears its panel records and
reports the original and cleanup errors without interrupting ordinary
shutdown. An asynchronous drawing failure after context retirement is retained
as the controller's `lastError`, without writing into a retired panel.
- Terminal protocol/render/repair failures stop only the compound job and freeze
verified pairs and panel records with an explicit error and reconnect guidance.
Pending candle waits and late creates/repairs lose presentation ownership;
incomplete pairs are removed, while surviving verified entities remain.
The existing context timer continues decision-time age pruning after failure,
and manual clear and context retirement remain effective. Native cleanup
attempts every retired entity once and aggregates failures without retrying an
unknown removal. Cleanup errors do not interrupt ordinary shutdown or discard
unrelated retained history. An asynchronous drawing failure after context
retirement is retained as `lastError`, without writing into a retired panel.
- Each candidate owns a 36-pixel native icon arrow and a short text label:
dark red down/`候选高` above the candle, dark green up/`候选低` below it.
Annotation direction remains `arrow_down`/`arrow_up`; native drawing options
Expand Down
109 changes: 63 additions & 46 deletions scripts/binance-strategy27-events.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// @namespace binance.strategy27.events
// @icon data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @icon64 data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2064%2064%22%3E%3Crect%20width%3D%2264%22%20height%3D%2264%22%20rx%3D%2214%22%20fill%3D%22%23f0b90b%22%2F%3E%3Ctext%20x%3D%2232%22%20y%3D%2249%22%20text-anchor%3D%22middle%22%20font-family%3D%22Arial%2C%20sans-serif%22%20font-size%3D%2242%22%20font-weight%3D%22800%22%20fill%3D%22%23111827%22%3EJ%3C%2Ftext%3E%3C%2Fsvg%3E
// @version 0.6.1
// @version 0.6.2
// @author jackhai9
// @description Display Strategy 27 events and provide the shared private CorsairQuant gateway connection
// @match https://www.binance.com/*/futures/*
Expand Down Expand Up @@ -2445,16 +2445,20 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
this.reset("initial_cursor");
}
reset(reason) {
check2(["initial_cursor", "stale_cursor", "route_changed", "interval_changed", "unavailable", "stopped"].includes(reason), "reset reason is invalid");
__privateSet(this, _generation, __privateGet(this, _generation) + 1);
this.resetProtocol(reason);
__privateGet(this, _records).clear();
__privateSet(this, _evictionBoundary, null);
}
/** Invalidate in-flight validation without retiring verified observations. */
resetProtocol(reason) {
check2(["initial_cursor", "stale_cursor", "route_changed", "interval_changed", "unavailable", "stopped"].includes(reason), "reset reason is invalid");
__privateSet(this, _generation, __privateGet(this, _generation) + 1);
this.runtimeEpoch = null;
this.lastSequence = null;
}
beginBootstrap(runtimeEpoch) {
check2(typeof runtimeEpoch === "string" && /^[a-f0-9]{32}$/.test(runtimeEpoch), "bootstrap epoch is invalid");
this.reset("initial_cursor");
this.resetProtocol("initial_cursor");
this.runtimeEpoch = runtimeEpoch;
this.lastSequence = 0;
}
Expand Down Expand Up @@ -2494,10 +2498,7 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
this.runtimeEpoch = envelope.runtime_epoch;
this.lastSequence = envelope.sequence;
if (isState) {
const removedCandidateIds2 = [...__privateGet(this, _records).keys()];
__privateGet(this, _records).clear();
__privateSet(this, _evictionBoundary, null);
return { type: "stream_reset", removedCandidateIds: removedCandidateIds2 };
return { type: "stream_reset", removedCandidateIds: this.prune(nowMs) };
}
const removedCandidateIds = this.prune(nowMs);
if (envelope.message_kind === "heartbeat") return { type: "heartbeat", removedCandidateIds };
Expand Down Expand Up @@ -2569,17 +2570,19 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
return CONNECTION_STATUS;
}
function renderStatus() {
if (lastError) panel.setCompoundStatus(t("复合候选已停止：", "Compound candidates stopped: ") + lastError.message, "error");
if (lastError) panel.setCompoundStatus(t("复合候选已停止，历史记录已保留。请使用重新连接菜单恢复：", "Compound candidates stopped; history retained. Use the reconnect menu to resume: ") + lastError.message, "error");
else panel.setCompoundStatus(...connectionStatus()[connectionState]);
}
const lifecycle = new CompoundCandidateLifecycle(canonicalSymbol, { maxCandidates, maxAgeMs });
const abortController = new AbortController();
let layer = null;
let started = false;
let stopped = false;
let viewGeneration = 0;
let pendingCandidateId = null;
let lastError = null;
const current = () => !abortController.signal.aborted && isCurrent();
const ownsContext = () => !stopped && isCurrent();
const current = () => !abortController.signal.aborted && ownsContext();
function clearView() {
viewGeneration += 1;
pendingCandidateId = null;
Expand All @@ -2593,56 +2596,64 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
return cleanupError;
}
function remove(ids) {
const errors = [];
for (const id of ids) {
if (id === pendingCandidateId) viewGeneration += 1;
layer?.remove(id);
try {
layer?.remove(id);
} catch (error) {
errors.push(error);
}
panel.removeCompound(id);
}
if (errors.length === 1) throw errors[0];
if (errors.length > 1) throw new AggregateError(errors, errors.map((error) => error.message).join("; "));
}
function prune(observedAtMs = nowMs()) {
if (current()) remove(lifecycle.prune(observedAtMs));
if (ownsContext()) remove(lifecycle.prune(observedAtMs));
}
function failJob(error, { clear = true } = {}) {
lastError = error;
if (!current()) return;
function suspendView() {
viewGeneration += 1;
pendingCandidateId = null;
layer?.suspend();
}
function failJob(error) {
lastError = lastError === null || lastError === error ? error : new AggregateError([lastError, error], `${lastError.message}; ${error.message}`);
if (!ownsContext()) return;
abortController.abort();
lifecycle.reset("stopped");
const cleanupError = clear ? clearView() : null;
if (cleanupError) lastError = new AggregateError([error, cleanupError], `${error.message}; ${cleanupError.message}`);
lifecycle.resetProtocol("stopped");
try {
suspendView();
} catch (cleanupError) {
lastError = new AggregateError([lastError, cleanupError], `${lastError.message}; ${cleanupError.message}`);
}
renderStatus();
}
function onConnectionStateChange(state) {
if (!current()) return;
const status = connectionStatus()[state];
if (!status) throw new Error(`Unknown compound connection state: ${state}`);
if (state === "unavailable" || state === "unsupported") {
lifecycle.reset("unavailable");
const error = clearView();
if (error) {
failJob(error, { clear: false });
return;
}
lifecycle.resetProtocol("unavailable");
}
if (state === "unsupported") {
abortController.abort();
suspendView();
}
connectionState = state;
renderStatus();
}
async function onResponse(response) {
if (!current()) return;
prune();
if (response.status === "reset") {
lifecycle.reset(response.reason);
const error = clearView();
if (error) failJob(error, { clear: false });
lifecycle.resetProtocol(response.reason);
return;
}
let messages = response.messages;
const applicationNowMs = response.status === "bootstrap" ? response.bootstrap_observed_at_ms : nowMs();
if (response.status === "bootstrap") {
lifecycle.beginBootstrap(response.runtime_epoch);
const error = clearView();
if (error) {
failJob(error, { clear: false });
return;
}
messages = [...response.records].sort((left, right) => left.sequence - right.sequence);
}
for (const message of messages) {
Expand All @@ -2652,11 +2663,6 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
if (!current()) return;
remove(action.removedCandidateIds);
if (action.type === "stream_reset") {
const error = clearView();
if (error) {
failJob(error, { clear: false });
return;
}
continue;
}
if (action.type !== "candidate" || applicationGeneration !== viewGeneration) continue;
Expand Down Expand Up @@ -2716,9 +2722,9 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
})();
},
clear() {
if (!current()) return;
if (!ownsContext()) return;
const error = clearView();
if (error) failJob(error, { clear: false });
if (error) failJob(error);
},
prune() {
try {
Expand All @@ -2736,13 +2742,14 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
}
},
stop(reason) {
if (abortController.signal.aborted) return;
if (stopped) return;
stopped = true;
abortController.abort();
lifecycle.reset(reason);
const error = clearView();
if (error) {
lastError = error;
renderStatus();
lastError = lastError === null ? error : new AggregateError([lastError, error], `${lastError.message}; ${error.message}`);
if (isCurrent()) renderStatus();
}
},
// A late drawing rejection remains inspectable without touching a retired panel.
Expand Down Expand Up @@ -2777,6 +2784,7 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
const records = /* @__PURE__ */ new Map();
let pending = null;
let reconciliation = null;
let suspended = false;
function dispose(recordsToRemove) {
const errors = [];
const liveIds = readLiveShapeIds(chart);
Expand Down Expand Up @@ -2811,7 +2819,7 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
}
function restoreCandidate(id, record, liveIds) {
if (record.restoring) return record.restoring;
const current = () => records.get(id) === record && isChartCurrent();
const current = () => !suspended && records.get(id) === record && isChartCurrent();
if (!current()) return Promise.resolve(false);
if (record.ids.every((entityId) => liveIds.has(entityId))) return Promise.resolve(true);
record.restoring = (async () => {
Expand All @@ -2835,11 +2843,12 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
return record.restoring;
}
function reconcile() {
if (suspended) return Promise.resolve();
if (reconciliation) return reconciliation;
reconciliation = (async () => {
let liveIds = readLiveShapeIds(chart);
for (const [id, record] of [...records]) {
if (records.get(id) !== record || !isChartCurrent()) continue;
if (suspended || records.get(id) !== record || !isChartCurrent()) continue;
if (!record.restoring && record.ids.every((entityId) => liveIds.has(entityId))) continue;
await restoreCandidate(id, record, liveIds);
liveIds = readLiveShapeIds(chart);
Expand Down Expand Up @@ -2870,6 +2879,7 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
dispose(removals);
}
async function renderCandidate(id, annotation, decisionAtMs) {
if (suspended) return false;
const existing = records.get(id);
if (existing) return restoreCandidate(id, existing, readLiveShapeIds(chart));
if (pending !== null) throw new Error("Compound chart rendering must be serial");
Expand Down Expand Up @@ -2902,11 +2912,11 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
for (const [drawingPoint, drawing] of drawings) {
const entityId = await createDrawing(drawingPoint, drawing);
operation.ids.push(entityId);
if (drawing.shape === "text") updateLabel(entityId, drawing, annotation.markerShape);
if (operation.controller.signal.aborted || !isChartCurrent()) {
dispose([operation]);
return false;
}
if (drawing.shape === "text") updateLabel(entityId, drawing, annotation.markerShape);
}
records.set(id, { ids: operation.ids.splice(0), group, slot, decisionAtMs, markerShape: annotation.markerShape, drawings, restoring: null });
return true;
Expand Down Expand Up @@ -2940,7 +2950,14 @@ ${t("候选", "Candidate")} ${annotation.candidateId}`,
if (liveIds.has(record.ids[1])) updateLabel(record.ids[1], drawing, record.markerShape);
}
}
return Object.freeze({ setLocale, renderCandidate, reconcile, remove, clear, get size() {
function suspend() {
suspended = true;
if (pending) {
pending.controller.abort();
dispose([pending]);
}
}
return Object.freeze({ setLocale, renderCandidate, reconcile, remove, clear, suspend, get size() {
return records.size;
} });
}
Expand Down
Loading
Loading