fix(strategy29): balance recent signals and simplify summary diagnostics - #293
Merged
Conversation
- retain three recent signals per configured timeframe before ordering by close time - synchronize interval configuration changes through bounded snapshots - move technical status details into a collapsed diagnostics section - release Strategy29 0.5.5 and Strategy27 0.6.5 with the shared request contract
- require V4 status and event envelopes while preserving V2 event identities - reject an old backend before requesting snapshots and reject cross-version pages - regenerate the Strategy29 artifact and align fixtures and documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-minute signals could fill the recent cross-timeframe list and hide retained signals from longer intervals. Keep the latest three signals for each configured timeframe, then sort the combined list by close time and sequence. Intervals without retained signals show an empty-history explanation instead of fabricated rows.
The main panel focuses on the symbol, connection, monitoring coverage, event check time, signals, and actionable exceptions. Specification and local code versions, universe details, processing rows, and global notification diagnostics move into a collapsed diagnostics section. Processing rows use interval duration order.
Strategy29 requests the bounded
latest_per_timeframesnapshot and resets its cursor when the nonempty configured interval set changes. The shared request whitelist is updated in both Strategy29 0.5.5 and its Strategy27 0.6.5 provider. The client requires v4 API envelopes and retains v2 event identities. An old backend is rejected before event requests; a backend version change between status and events cannot publish a stale-version page or advance the cursor. Install identities and update URLs are preserved.Deployment dependency: https://github.com/jackhai9/CorsairQuant/pull/344 must finish deployment before this PR is merged and the new clients are installed.
Validation:
npm test: 1,032 passed. Playwright UI suite: 83 passed.git diff --checkpassed.userscript_final_reviewreturned GO on 2026-09-13 with no actionable findings for the summary implementation. The reviewer independently ran 57 focused tests, checked both generated files byte-for-byte using in-memory builds, inspected existing rendered previews, and reported no write actions. The version-boundary follow-up review is recorded below.Artifact SHA-256:
dd7d989a64c24b8d2956fa73d52e83bb811687b0f1f0efbfc9b394d3ffe4c427.be0db522b84864245c086d30190dd9bf55e245cb879667bd23ee800d90e7c2b8.Rendered checks use synthetic pages. Production Binance behavior and installed-source verification are post-release checks. Signal detection, notification enablement, and trading actions are unchanged.
Version-boundary follow-up review:
api_version_final_review, 2026-09-13, GO with no remaining findings after correcting two current documentation references to V4. The reviewer independently passed 31 client contract tests and verified the generated artifact byte-for-byte using an in-memory build. No write actions were performed; post-review status and reflog matched the primary agent's changes.