Repository navigation
fix: handle nested value format in _update_user_info - #408
Open
hambergerpls wants to merge 1 commit into
Open
hambergerpls wants to merge 1 commit into
hambergerpls wants to merge 1 commit into
Conversation
Notion's internal API now wraps record values in an extra nesting layer:
{"value": {"value": {...data}, "role": "editor"}}
instead of the previous flat format:
{"value": {...data}, "role": "editor"}
store_recordmap in store.py already handles this, but _update_user_info
accessed the raw records dict before store_recordmap, hitting the old
single-level assumption on the space_view_pointers lookup.
Extract a reusable _unwrap_record_value helper and use it to safely
resolve space_view_pointers regardless of nesting depth.
Fixes jamalex#407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyError: 'space_view_pointers'in_update_user_infocaused by Notion's API nesting format change_unwrap_record_valuestatic method that handles both old and new record formats.get()with defaults throughout to avoid hard crashes on missing keysCloses #407