Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL export bypasses Dataset formatters by iterating stored rows directly. A formatter registered with
add_formatter()affects other exports but is silently ignored by SQL, so generated INSERT values differ from the requested export transformations.Render SQL values from the existing formatted list representation, omitting its header row while preserving column order and duplicate header behavior. The stored Dataset values remain unchanged. Two regressions cover a named-column formatter with headers and an all-column formatter without headers and with explicit SQL column names.
Validation on Python 3.13: both new cases fail before the fix, and all 185 tests pass after it with the format dependencies and pandas installed. Whole source/test Ruff checks and
git diff --checkpass. Other interpreters and hosted CI results have not been verified.