Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a column leaves formatter positions unchanged. With headers
id, name, cityandadd_formatter('name', str.upper), deletingidexports the name unchanged and uppercases the city instead. Deleting the formatted column can also apply its callback to the next column or raise an indexing/type error.Remap surviving formatter positions and remove callbacks for the deleted column. Preserve global callback order and negative indices' existing relative-to-end behavior, including after a later
append_col.Tests cover preceding/deleted columns, named and integer references, global callback order and negative-index compatibility. The original source produces six regression failures. The fixed full test suite passes on Windows CPython 3.12.14 and 3.13.5: 187 tests and 6 subtests each. The 3.13 run also collected coverage. Ruff and
git diff --checkpass, and an independent review reran the focused tests. Optional pandas, other platforms/interpreters, full tox and package builds were not checked.AI assistance (OpenAI Codex) was used to investigate, implement, review and test this change.