Remove useless floatval() cast in history::getHistoryFromCalcul - #3399
Open
Salvialf wants to merge 1 commit into
Open
Remove useless floatval() cast in history::getHistoryFromCalcul#3399Salvialf wants to merge 1 commit into
Salvialf wants to merge 1 commit into
Conversation
Mips2648
approved these changes
Jun 27, 2026
Salvialf
added
changelog-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strtotime()returnsint|false. Wrapping it infloatval()converts the result to a float, but PHP silently truncates floats back to integers when used as array keys, making the cast a no-op with no effect on behavior.Removing it makes the intent explicit: the key is a Unix timestamp (integer).
Changes
history.class.php:$datetime = floatval(strtotime(...))→$datetime = strtotime(...)