Skip to content

[BUG-451] Allow setting imagePullSecrets for Deployment #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michizubi-SRF wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −2
Open

[BUG-451] Allow setting imagePullSecrets for Deployment #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5012e81
BUG-451 Allow setting imagePullSecrets for Deployment
michizubi-SRF Aug 3, 2026
2735ba1
Remove temporary file
michizubi-SRF Aug 3, 2026
0682c65
Remove whitespace
michizubi-SRF Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions deploy/charts/version-checker/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ spec:
volumeMounts:
{{- toYaml . | nindent 10 }}
{{- end }}
{{- if .Values.imagePullSecrets }}
imagePullSecrets:
{{ toYaml .Values.imagePullSecrets | indent 2 }}
{{- end }}
{{- with .Values.podSecurityContext }}
securityContext:
{{- toYaml . | nindent 8 }}
Expand Down
5 changes: 3 additions & 2 deletions deploy/charts/version-checker/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ nameOverride: ""
# -- Replica Count for version-checker
replicaCount: 1

# -- Pull secrects - names of existing secrets
imagePullSecrets: []

# -- Additional Labels to apply to Service and Deployment/Pod Objects
additionalLabels: {}
# -- Additional Annotations to apply to Service and Deployment/Pod Objects
Expand All @@ -20,8 +23,6 @@ image:
tag: ""
# -- Set the Image Pull Policy
pullPolicy: IfNotPresent
# -- Pull secrects - name of existing secret
imagePullSecret:

# -- Configure tolerations
tolerations: []
Expand Down
Loading