Fix JSON Patch move and copy array targets#136
Open
gaoflow wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addtarget semantics tomoveandcopyoperations-array target for appending moved or copied valuesProblem
RFC 6902 defines
moveas a removal followed byadd, andcopyasaddusing the source value. The implementation handled their destinations separately withlist.insert(), bypassing the boundary behavior fixed foraddin #118. As a result, an array target ending in-leaked a nativeValueError, while an index greater than the array length was silently clamped to the end by Python.Delegating the destination step to
OpAddkeeps these three standard operations on one target implementation while preserving the deep copy required bycopy.Testing
2828 passed, 1 skippedruff check .mypy(86 source files)