Repository navigation
Cranker: Retry stake pool update with no_merge on failure - #68
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a fallback stake-pool update that disables merging after the initial attempt fails.
Changes:
- Retries failed updates with
no_merge. - Adds outcome-specific Slack notifications.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
no_merge on failure
hash-envy
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The testnet stake pool is currently in a state where the update cannot complete with
merging enabled.
UpdateValidatorListBalancefails on the merge of transient stakeaccounts, and because that failure aborts the whole update, the cranker never finishes
the epoch update at all —
last_update_epochstays behind the current epoch, which inturn blocks deposits and withdrawals against the pool until someone manually runs the
update with
--no-merge.Merging is the failure-prone part of the update (a transient stake account that is still
activating/deactivating cannot be merged), but it is also the optional part: the
balance and state update for every validator is what actually needs to land each epoch.
Change
If the first pass (
no_merge = false) fails, the cranker now retries once withno_merge = true, so the balance/state update still lands even when transient stakeaccounts cannot be merged. The Slack notification distinguishes the two success paths, so
it is visible when an epoch was cranked without merging rather than silently succeeding.
No config or CLI changes — the retry is automatic.
Notes
parallel_execute_stake_pool_update: it re-fetches the pooland validator list and re-sends every
UpdateValidatorListBalancechunk, not just thefailed ones.
force: truebypasses thelast_update_epochearly return, and repeatedupdates within an epoch are idempotent, so this is safe — the cost is a second full
pass of transactions and fees on the failure path.
they finish activating/deactivating.
Test plan
retry with
no_mergesucceeds,last_update_epochadvances to the current epoch, andthe Slack message reports the no-merge path.
runs.